Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional dependencies and required dev-deps #5454

Merged
merged 1 commit into from
May 2, 2018

Conversation

alexcrichton
Copy link
Member

This fixes an accidental bug introduced in #5300 by ensuring a local map keeps
track of the fact that there can be multiple dependencies for one name

Closes #5453

This fixes an accidental bug introduced in rust-lang#5300 by ensuring a local map keeps
track of the fact that there can be multiple dependencies for one name

Closes rust-lang#5453
@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

cc @djc

r? @matklad

@alexcrichton alexcrichton reopened this May 2, 2018
@djc
Copy link
Contributor

djc commented May 2, 2018

Ah, crap, I missed that this was possible. Your fix makes sense, though.

@matklad
Copy link
Member

matklad commented May 2, 2018

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2018

📌 Commit 02b0dba has been approved by matklad

@bors
Copy link
Contributor

bors commented May 2, 2018

⌛ Testing commit 02b0dba with merge 1b26ece...

bors added a commit that referenced this pull request May 2, 2018
Fix optional dependencies and required dev-deps

This fixes an accidental bug introduced in #5300 by ensuring a local map keeps
track of the fact that there can be multiple dependencies for one name

Closes #5453
@bors
Copy link
Contributor

bors commented May 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 1b26ece to master...

@bors bors merged commit 02b0dba into rust-lang:master May 2, 2018
@alexcrichton alexcrichton deleted the fix branch May 10, 2018 19:17
@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build project with serde with latest cargo
6 participants