Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build project with serde with latest cargo #5453

Closed
ehuss opened this issue May 1, 2018 · 2 comments · Fixed by #5454
Closed

Can't build project with serde with latest cargo #5453

ehuss opened this issue May 1, 2018 · 2 comments · Fixed by #5454

Comments

@ehuss
Copy link
Contributor

ehuss commented May 1, 2018

Building a project with a dependency serde = "1.0" causes the following error:

error: no matching version `^1.0` found for package `serde`
location searched: registry `https://github.com/rust-lang/crates.io-index`
versions found: 0.9.6, 0.9.5, 0.9.4, ...

This might be caused by #5300 (cc @djc).
@alexcrichton
Copy link
Member

Thanks for the report @ehuss! I've found the issue and am working on a test.

alexcrichton added a commit to alexcrichton/cargo that referenced this issue May 2, 2018
@alexcrichton
Fix optional dependencies and required dev-deps
02b0dba 
This fixes an accidental bug introduced in rust-lang#5300 by ensuring a local map keeps
track of the fact that there can be multiple dependencies for one name

Closes rust-lang#5453
@alexcrichton alexcrichton mentioned this issue May 2, 2018
Merged
@alexcrichton
Copy link
Member

This should be fixed at #5454

bors added a commit that referenced this issue May 2, 2018
@bors
Auto merge of #5454 - alexcrichton:fix, r=matklad
1b26ece 
Fix optional dependencies and required dev-deps

This fixes an accidental bug introduced in #5300 by ensuring a local map keeps
track of the fact that there can be multiple dependencies for one name

Closes #5453
@bors bors closed this as completed in #5454 May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix optional dependencies and required dev-deps alexcrichton/cargo
2 participants
@ehuss @alexcrichton