Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta-1.79] fix(toml): Don't warn on lints.rust.unexpected_cfgs.check-cfg #13925

Merged
merged 11 commits into from
May 22, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented May 17, 2024

Beta backports:

In order to make CI pass, the following PRs are also cherry-picked:

epage added 2 commits May 17, 2024 12:36
While its unused, we thought we'd reduce warning noise for people using
this key on nightly.
@epage epage marked this pull request as draft May 17, 2024 17:40
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.79.0. Please double check that you specified the right target!

@rustbot rustbot added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2024
This is currently breaking CI because we run effectively `RUSTDOCFLAGS=-Dwarnings cargo +nightly doc`
@rustbot rustbot added the A-testing-cargo-itself Area: cargo's tests label May 17, 2024
@epage epage changed the title fix(toml): Don't warn on lints.rust.unexpected_cfgs.check-cfg [beta-1.79] fix(toml): Don't warn on lints.rust.unexpected_cfgs.check-cfg May 17, 2024
@epage epage marked this pull request as ready for review May 21, 2024 14:31
@epage
Copy link
Contributor Author

epage commented May 21, 2024

The nightly failure is being tracked in rust-lang/rust#125319. As such, I'll workaround by updating dependencies.

@rustbot rustbot added the A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. label May 22, 2024
@weihanglo
Copy link
Member

@bors r+

Thanks for doing all the messy works.

@bors
Copy link
Collaborator

bors commented May 22, 2024

📌 Commit 67aa704 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 22, 2024
@bors
Copy link
Collaborator

bors commented May 22, 2024

⌛ Testing commit 67aa704 with merge 92f61d0...

@bors
Copy link
Collaborator

bors commented May 22, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 92f61d0 to rust-1.79.0...

@bors bors merged commit 92f61d0 into rust-lang:rust-1.79.0 May 22, 2024
23 checks passed
@epage epage deleted the lint-config branch May 22, 2024 17:58
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2024
[beta-1.79] Update cargo

2 commits in 8a7384119af18fa4b3311c310661acd81f1b4885..9ca20fadf04af535ec39d1e18c87cd886185d300
2024-05-03 01:19:24 +0000 to 2024-05-22 17:55:16 +0000
- [beta-1.79] upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13950)
- [beta-1.79] fix(toml): Don't warn on lints.rust.unexpected_cfgs.check-cfg (rust-lang/cargo#13925)

r? ghost
@rustbot rustbot added this to the 1.79.0 milestone May 23, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 25, 2024
…, r=Mark-Simulacrum

Bump bootstrap compiler to the latest beta compiler

This PR updates the bootstrap compiler, aka stage0 to the latest beta version, since it contains rust-lang/cargo#13925.

It removes those unconditional Cargo warnings:

```
warning: [...]/rust/library/core/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
warning: [...]/rust/library/std/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
warning: [...]/rust/library/alloc/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
```

for all contributors/users of this repository (including CI).

I don't know if that's something we do, or if it's even advisable, feel free to close.

r? `@Mark-Simulacrum`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
Rollup merge of rust-lang#125478 - Urgau:check-cfg-config-bump-stage0, r=Mark-Simulacrum

Bump bootstrap compiler to the latest beta compiler

This PR updates the bootstrap compiler, aka stage0 to the latest beta version, since it contains rust-lang/cargo#13925.

It removes those unconditional Cargo warnings:

```
warning: [...]/rust/library/core/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
warning: [...]/rust/library/std/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
warning: [...]/rust/library/alloc/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
```

for all contributors/users of this repository (including CI).

I don't know if that's something we do, or if it's even advisable, feel free to close.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-manifest Area: Cargo.toml issues A-testing-cargo-itself Area: cargo's tests Command-fix S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants