Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-cfg-related and rust-lld-related CI failures #1110

Merged
merged 4 commits into from
May 19, 2024

Conversation

ryoqun
Copy link
Contributor

@ryoqun ryoqun commented May 19, 2024

Fix master ci, which is broken due 2 problems:

@@ -63,5 +63,11 @@ members = [
missing_debug_implementations = "warn"
rust_2018_idioms = "warn"
single_use_lifetimes = "warn"
unexpected_cfgs = { level = "warn", check-cfg = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this warn isn't avoidable, when locally-developing crossbeam itself with any toolchain with the support of Cargo.toml's lints.rust and < nightly-2024-05-19..:

$ RUSTUP_TOOLCHAIN=1.78.0-x86_64-unknown-linux-gnu cargo check
warning: /home/ryoqun/work/crossbeam/Cargo.toml: unused manifest key: workspace.lints.rust.unexpected_cfgs.check-cfg
   Compiling crossbeam-utils v0.8.19 (/home/ryoqun/work/crossbeam/crossbeam-utils)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, we are working on making this warning go away in the current beta with rust-lang/cargo#13925, so that when it reaches stable, the warning would already be gone by the previous version.

@ryoqun
Copy link
Contributor Author

ryoqun commented May 19, 2024

@github-actions CI / careful (pull_request) Failing after 42s

well, well, well. celebrate rapid development progress of rust nightly? seems https://blog.rust-lang.org/2024/05/17/enabling-rust-lld-on-linux.html is the culprit for the careful failure...

@ryoqun ryoqun changed the title White-list custom cfgs for unexpected_cfgs lint Fix check-cfg-related and rust-lld-related CI failures May 19, 2024
@ryoqun
Copy link
Contributor Author

ryoqun commented May 19, 2024

@taiki-e Following from #1109 (comment), it seems ci is green again in another approach. could you review this?

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e marked this pull request as ready for review May 19, 2024 09:24
@taiki-e taiki-e merged commit 8cec8ec into crossbeam-rs:master May 19, 2024
23 checks passed
taiki-e added a commit that referenced this pull request May 19, 2024
taiki-e added a commit that referenced this pull request May 19, 2024
taiki-e added a commit that referenced this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants