Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an option to specify the ssl version used for cargo #6684

Closed
guanqun opened this issue Feb 20, 2019 · 0 comments · Fixed by #7308
Closed

add an option to specify the ssl version used for cargo #6684

guanqun opened this issue Feb 20, 2019 · 0 comments · Fixed by #7308
Labels
A-networking Area: networking issues, curl, etc. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@guanqun
Copy link

guanqun commented Feb 20, 2019 •
edited
Loading

For some reason, the current cargo (1.31.0 and 1.32.0) would use TLSv1.3 here, but due to the network issue (probably behind the corporate proxy), it fails. Rust verion 1.30.0 works fine as it uses TLSv1.2.

So I'd like to add a option in "http" that specifies the ssl version to use. With this alexcrichton/curl-rust#252 fixed, I think it's quite easy to add.

If you agree this is a good option, I can file a PR, (probably need to ask for a version bump for curl-rust first).
@guanqun guanqun added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Feb 20, 2019
@guanqun guanqun mentioned this issue Aug 29, 2019
Merged
@ehuss ehuss added the A-networking Area: networking issues, curl, etc. label Sep 23, 2019
bors added a commit that referenced this issue Sep 30, 2019
@bors
Auto merge of #7308 - guanqun:add-ssl-version, r=alexcrichton
8ae8b5e 
add an option to specify ssl version

Fixes #6684
@bors bors closed this as completed in 05d88bf Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-networking Area: networking issues, curl, etc. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add an option to specify ssl version guanqun/cargo
2 participants
@ehuss @guanqun