-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support more ssl versions #252
Comments
I think that was jut an artifact of when they were first added, should be fine to uncomment now! |
Thanks for the clarification, I've now created a PR to uncomment these enums and added a Tlsv13 too. Please help review. Thanks. |
Thanks for the merge, can we bump a version for this small feature? |
Sure! I noticed though that CI is failing on master, would you be willing to take a look at that? (I think it's caused by this PR) |
Sure! I checked the error log:
So it's due to the TLSv1_3 being not defined. I'm guessing that on that docker image, the curl header/library is too old. Notice that So I'd suggest upgrading |
That makes sense! We've got a number of other cases of constants like that, so I think this'd just need to be added to that list? |
I see that tlsv1.1 and tlsv1.2 are commented out in the code, see the following line:
curl-rust/src/easy/handler.rs
Line 484 in cf49823
any specific reason? I'd like to extend this SslVersion to support more versions. If you're OK, I can help send a simple PR.
The text was updated successfully, but these errors were encountered: