Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support more ssl versions #252

Closed
guanqun opened this issue Feb 14, 2019 · 6 comments · Fixed by #253
Closed

support more ssl versions #252

guanqun opened this issue Feb 14, 2019 · 6 comments · Fixed by #253

Comments

@guanqun
Copy link

guanqun commented Feb 14, 2019

I see that tlsv1.1 and tlsv1.2 are commented out in the code, see the following line:

// Tlsv12 = curl_sys::CURL_SSLVERSION_TLSv1_2 as isize,

any specific reason? I'd like to extend this SslVersion to support more versions. If you're OK, I can help send a simple PR.

@alexcrichton
Copy link
Owner

I think that was jut an artifact of when they were first added, should be fine to uncomment now!

@guanqun
Copy link
Author

guanqun commented Feb 15, 2019

Thanks for the clarification, I've now created a PR to uncomment these enums and added a Tlsv13 too. Please help review. Thanks.

@guanqun
Copy link
Author

guanqun commented Feb 20, 2019

Thanks for the merge, can we bump a version for this small feature?

@alexcrichton
Copy link
Owner

Sure! I noticed though that CI is failing on master, would you be willing to take a look at that? (I think it's caused by this PR)

@guanqun
Copy link
Author

guanqun commented Feb 21, 2019

Sure! I checked the error log:

cargo:warning=             static const CURLoption __test_const_CURL_SSLVERSION_TLSv1_3_val = CURL_SSLVERSION_TLSv1_3;
cargo:warning=                                                                                ^
cargo:warning=cc1: error: unrecognized command line option "-Wno-address-of-packed-member" [-Werror]
cargo:warning=cc1: all warnings being treated as errors
exit code: 1

So it's due to the TLSv1_3 being not defined. I'm guessing that on that docker image, the curl header/library is too old.

Notice that Dockerfile-linux64-curl uses ubuntu 14.04 while Dockerfile-linux64 uses ubuntu 16.04 and 16.04's version runs well for systest, see the below log:
https://travis-ci.com/alexcrichton/curl-rust/jobs/179317628

So I'd suggest upgrading Dockerfile-linux64-curl to use Ubuntu 16.04. If you agree this is a good move, I can create a simple PR.

@alexcrichton
Copy link
Owner

That makes sense! We've got a number of other cases of constants like that, so I think this'd just need to be added to that list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants