You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Pull requests are usually filed against the master branch for this repo, but this one is against v0.2.x. Please double check that you specified the right target!
199: InputPin instead of OutputPin for compatibility shim r=ryankurte a=AdminXVII
The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.
Co-authored-by: Xavier L'Heureux <dev.xlheureux@gmail.com>
Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
199: InputPin instead of OutputPin for compatibility shim r=ryankurte a=AdminXVII
The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.
Co-authored-by: Xavier L'Heureux <dev.xlheureux@gmail.com>
Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
Failed due to dyn keyword requirement that is / was fixed in 961dfb8, i need to update v0.2.x to the latest non-breaking change (rather than a mirror of 0.2.3)
220: [0.2.x] Fixes to digital compatibility shim r=ryankurte a=eldruin
I cherry-picked #138 and some improvements to docs and included #199.
Co-authored-by: Roma Sokolov <sokolov.r.v@gmail.com>
Co-authored-by: Ryan Kurte <ryankurte@gmail.com>
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdminXVII
requested review from
ilya-epifanov,
thejpster and
a team
as code owners
The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.