Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputPin instead of OutputPin for compatibility shim #194

Closed
wants to merge 1 commit into from

Conversation

AdminXVII
Copy link

The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.

The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ithinuel (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ryankurte ryankurte changed the base branch from master to v0.2.x April 4, 2020 22:19
@ryankurte ryankurte changed the base branch from v0.2.x to master April 4, 2020 22:19
@ryankurte
Copy link
Contributor

Thanks for opening this! We're doing a big refactor of master at the moment which is going to remove the previous pin versions, but should probably backport the fix.

I had a got at just swapping branches, but, this didn't work because it needs a rebase. If you'd like to land this could you open the same PR with just this change against the v0.2.x branch, and add this to the changelog?

@AdminXVII
Copy link
Author

Done in #199.

Closing this in favor of the other MR.

@AdminXVII AdminXVII closed this Apr 7, 2020
@AdminXVII AdminXVII deleted the patch-1 branch April 7, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants