This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Use volatile read for ICSR register #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the compiler from optimizing the read
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
lulf
force-pushed
the
prevent-optimized-read
branch
from
58e391c to
fa65b66
Compare
The 9th bit is needed to all 480 interrupts on Cortex-M33
bors bot
added a commit
that referenced
this pull request
Mar 2, 2021
315: Use volatile read for ICSR register r=adamgreig a=lulf This prevents the compiler from optimizing the read. Edit: I also added a change to include the 9th bit in the IRQ. I can leave that out if it would break anything. #314 Co-authored-by: Ulf Lilleengen <ulf.lilleengen@gmail.com>
|
Build failed: |
|
bors retry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the compiler from optimizing the read.
Edit: I also added a change to include the 9th bit in the IRQ. I can leave that out if it would break anything.
#314