Adjust for r e c #212
Adjust for r e c #212
Conversation
Rename config to config.toml as expect by modern cargo and use probe-rs rather then the deprecated probe-run tool
The STM32F103C8T6 only has 64K of flash; Unsure how 128K could work before, potentially probe-run didn't check while probe-rs does
rustdoc doesn't like unneeded explicit doc link targets, so drop them
Now that the crate has moved to rust-embedded-community drop the funding information for James
The circleci runs for this crate seem inaccessible and github actions is better integrated anyway.
|
Successful github actions can be found in my repo :) |
| @@ -1,6 +1,6 @@ | |||
| /* Linker script for the STM32F103C8T6 */ | |||
| MEMORY | |||
| { | |||
| FLASH : ORIGIN = 0x08000000, LENGTH = 128K | |||
| FLASH : ORIGIN = 0x08000000, LENGTH = 64K | |||
There was a problem hiding this comment.
Is there a reason to change this?
There was a problem hiding this comment.
probe-rs will refuse to flash the chip as the the memory doesn't match the chip memory; as noted in the commit message no idea how this worked previously :)
There was a problem hiding this comment.
Fwiw independantly ran into a note that there are some variants of the stm32f103 on some blue pills that do have 128K ; so i wonder if @jamwaffles has one of those ;) .. the STM32F103C8T6 officially only has 64K though
There was a problem hiding this comment.
That's exactly it! I don't think I own a single non-bootleg F103 😁
FWIW this setup is way out of date. I believe these days one doesn't need to provide their own memory.x, so this file could probably be deleted.
There was a problem hiding this comment.
not with stm32f1xx-hal afaik; i'm prepping a follow-up PR that moves the examples to embassy for the pac (as that implements hal 1.x) together with the patches from #207 so that that can be merged hopefully.. That will also drop memory.x
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
sjoerdsimons
force-pushed
the
adjust-for-r-e-c
branch
from
d443007 to
1c09604
Compare
|
@eldruin thanks for merging! Looks like someone needs to disable the circleci app such that github declares CI as succeeding (currently it fails because there is no circleci config...) |
Hi! Thank you for helping out with SSD1306 development! Please:
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepPR description
Various updates now it's hosted on r-e-c: