-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to embedded-hal-1.0.0 #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from a tweak to the changelog. I appreciate the attention to detail in changing the CI config too - thanks!
P.s. CI is failing. I don't have much time to look into it right now so I'd appreciate it if you can see if you can fix the issues. |
Thanks for the information. I will have a look by time. BR |
The main reason of failing is the missing embedded-hal 1.0.0 support for stm32f1xx-hal. Maybe the examples should be migrated to stm32f4xx-hal (already has 1.0.0) or disable until an implementation is available. |
Any progress on this? I've been using my own embedded-hal v1.0.0 fork instead, however this seems a little more polished than mine. I would be happy to migrate the CI to another platform if needed! |
@Sycrosity Currently not. All examples use the stm32f1xx-hal library. This library currently has no support for embedded hal 1.0 which is the main reason for the currently paused development. |
If it would help, I would happily switch the examples over to something like |
Any progress so far? I would also much appreciate if this PR would be merged as it also solves my issue (#211). |
Currently not because of lack of time. A workaround would be to use https://github.com/ryankurte/embedded-hal-compat which has now offical support for embedded-hal 1.0.0 BR, |
Fixed in #213. Thank you for your work! |
Hi! Thank you for helping out with SSD1306 development! Please:
master
if you're not already up to dateCHANGELOG.md
entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmt
on the project withcargo fmt --all
- CI will not pass without this stepPR description
Updated to embedded-hal 1.0.0
Updated rust-version to 1.75 for display-interface package