Bug fix for cluster server connection setup

[mattwillo]

Hi,

I have committed a patch that fixes Elastica\Client::_initConnections();

The config call and server setup wasn't working correctly with an array server setup.

[ruflin]

@munkie @webpatser @christeredvartsen Can you check if this is actually a bug or if it should actually be able to handle an array?

@mattwillo Can you post the structure of your servers array?

[mattwillo]

@ruflin My array looks like this

$servers = array(
array('host' => 'foo.mydomain.com', 'port' => 9200),
array('host' => 'bar.mydomain.com', 'port' => 9200)
);

[ruflin]

Ok. I think you are right and the issues is really the foreach. What is important to note is that servers is deprecated and connections should be used ...

[mattwillo]

I understand your point, but I think it is a nice feature to have, other clusters (e.g. RabbitMQ) provide the same functionality that will allow you to use a Connection to create one or just pass an array and let the library handle it.

I would consider keeping this as a feature.

Thanks

Matt

[ruflin]

Ok I think we have a small misunderstanding here. servers is deprecated, because it was replaced through the keyword connections (in the config option). The array structure etc. is still the same. If you look at this pull request from @munkie it will be even extended. #357 So don't worry, it is not planned to remove this feature.

[mattwillo]

Yes, that was a misunderstanding. Excellent, the Pool functionality looks great!