Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection pool & strategy #357

Closed
wants to merge 2 commits into from
Closed

Conversation

munkie
Copy link
Contributor

@munkie munkie commented Mar 22, 2013

As was discussed in #356, wrote some code to illustrate connection pool & strategy concept

@ruflin
Copy link
Owner

ruflin commented Mar 31, 2013

Sorry that I didn't give a detailed feedback to this so far. My first impression so far: Wow, this is big :-) At the moment I'm not if this is positive or not. It looks quite powerful and I think it is. But at the same time, it adds quite some complexity. The good part is, that it simplifies the client and moves the complexity to the connection pool. It also looks like the complexity is "hidden" for most of the users using Elastica which is good.

@daFish
Copy link
Contributor

daFish commented Apr 1, 2013

@ruflin Yes, it adds a bit of complexity but this added complexity is nicely hidden as you explained. Really powerful and clean.

@ruflin
Copy link
Owner

ruflin commented Apr 2, 2013

Ok, lets move forward here and get it into master (means adding test and finalizing it ;-) ).

@ruflin
Copy link
Owner

ruflin commented May 18, 2013

@munkie Do you have some time to finalize this?

@ruflin
Copy link
Owner

ruflin commented Mar 6, 2014

@daFish @munkie Any updates here?

@daFish
Copy link
Contributor

daFish commented Mar 6, 2014

@ruflin I'm not involved in the development so I can't give you an update on the situation. Let's here what @munkie has to say. :)

@munkie
Copy link
Contributor Author

munkie commented Mar 8, 2014

@ruflin I't was so long ago .. )) You can close this PR if there is no need for connection poll strategy anymore

@ruflin
Copy link
Owner

ruflin commented Mar 9, 2014

The reason I didn't close it because I'm quite sure there is a need for the connection pool strategy. I still hope someone picks it up and finishes it.

@ruflin
Copy link
Owner

ruflin commented Aug 20, 2014

Closed because of #661

@ruflin ruflin closed this Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants