-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection pool & strategy #357
Conversation
Sorry that I didn't give a detailed feedback to this so far. My first impression so far: Wow, this is big :-) At the moment I'm not if this is positive or not. It looks quite powerful and I think it is. But at the same time, it adds quite some complexity. The good part is, that it simplifies the client and moves the complexity to the connection pool. It also looks like the complexity is "hidden" for most of the users using Elastica which is good. |
@ruflin Yes, it adds a bit of complexity but this added complexity is nicely hidden as you explained. Really powerful and clean. |
Ok, lets move forward here and get it into master (means adding test and finalizing it ;-) ). |
@munkie Do you have some time to finalize this? |
@ruflin I't was so long ago .. )) You can close this PR if there is no need for connection poll strategy anymore |
The reason I didn't close it because I'm quite sure there is a need for the connection pool strategy. I still hope someone picks it up and finishes it. |
Closed because of #661 |
As was discussed in #356, wrote some code to illustrate connection pool & strategy concept