[6.x] Allow psr/log v2 and v3 #2183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @aistis- I'm happy to get this in but please we aware that there are no other releases planned for 6.x at the moment. |
|
@aistis- Some of the CI tests are failing. I don't think this is because of your change but because some parts in the geo lib have been updated. It needs an adjustment in at least on of the test for the geo values. |
aistisstramkauskas
added a commit
to hometogo/Elastica
that referenced
this pull request
Dec 14, 2023
See the PR to the original repository ruflin#2183
|
Hi @ruflin and thanks for feedback! Should I look into the failing tests and try to fix them? Indeed, they seems broken, but not because of added |
That would be great! I hope it is mostly about adjusting some values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we allow psr/log v2 or v3 to elastica v7+. This is a backport support for elastica v6. No changes from the code itself is necessary.