Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr/log 2.0 + 3.0 #1971

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Allow psr/log 2.0 + 3.0 #1971

merged 3 commits into from
Aug 5, 2021

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Aug 2, 2021

psr/log 2.0 was tagged a couple of weeks ago: https://twitter.com/phpfig/status/1415413578191024130

3.0 has been tagged too, and it can be allowed since the interface us just used but not implemented anywhere.
This PR is also a blocker for Seldaek/monolog#1564

More details are available in the new meta document: https://www.php-fig.org/psr/psr-3/meta/

@ruflin ruflin requested a review from deguif August 2, 2021 13:10
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM (have not digged into 3.0 but trust you on this one :-). Could you add a changelog entry?

@Jean85
Copy link
Contributor Author

Jean85 commented Aug 4, 2021

Done!

@ruflin ruflin merged commit e137d9f into ruflin:master Aug 5, 2021
@ruflin
Copy link
Owner

ruflin commented Aug 5, 2021

@Jean85 Thank you for the contribution!

@Jean85 Jean85 deleted the patch-1 branch August 27, 2021 06:40
@deguif deguif added this to the 7.2.0 milestone Sep 3, 2021
@deguif deguif modified the milestones: 7.2.0, 7.1.2 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants