Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8 in composer.json #1914

Closed
wants to merge 1 commit into from
Closed

Allow PHP 8 in composer.json #1914

wants to merge 1 commit into from

Conversation

soltmar
Copy link

@soltmar soltmar commented Mar 15, 2021

Simple change to allow PHP 8 on Elastica 6.x

@deguif
Copy link
Collaborator

deguif commented Mar 15, 2021

@soltmar branch 6.x is not compatible with PHP 8.0 because of theQuery\Match class.
See #1898 (review) for reference.

@ruflin
Copy link
Owner

ruflin commented Mar 16, 2021

Thanks for chiming in @deguif . I also realised we still don't have builds for the 6.x branch. Seems #1905 did not make it yet.

@deguif
Copy link
Collaborator

deguif commented Mar 16, 2021

I've just migrated CI to github action for 6.x branch (#1918).
Allowing PHP 8.0 on this branch will not be that easy if we want to test it (phpunit version constraint nightmares).

@reedy
Copy link
Contributor

reedy commented Sep 22, 2021

Should be closed.. Hopefully in favour of #1977 being finished

@reedy
Copy link
Contributor

reedy commented Sep 30, 2021

#1981 was merged to do this. PR should be closed

@thePanz thePanz closed this Oct 8, 2021
@soltmar soltmar deleted the 6.x branch October 19, 2021 15:20
@soltmar soltmar restored the 6.x branch October 19, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soltmar @deguif @ruflin @reedy @thePanz