Add MatchQuery class for forward compat #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedy
commented
Feb 11, 2021
| @@ -8,6 +8,8 @@ | |||
| * @author F21 | |||
| * @author WONG Wing Lun <luiges90@gmail.com> | |||
| * | |||
| * @deprecated since version 6.1.2, use the MatchQuery class instead. | |||
There was a problem hiding this comment.
Guessed that 6.1.2 would be the next release of 6.x..
deguif
reviewed
Feb 11, 2021
deguif
approved these changes
Feb 12, 2021
ruflin
approved these changes
Feb 15, 2021
reedy
commented
Feb 16, 2021
| * This class is for forward compatibility reasons. For PHP 8 and above use MatchQuery as Match is reserved. | ||
| */ | ||
| class MatchQuery extends Match | ||
| { |
There was a problem hiding this comment.
Well, this is embarrassing. And apparently CI didn't pick this up.
This isn't valid PHP, there's a missing }
There was a problem hiding this comment.
Yes CI didn't pick it on 6.x as it was broken when Travis stopped testing when quota was reached.
On 7.x CI was migrated to github action.
reedy
added a commit
to reedy/Elastica
that referenced
this pull request
Feb 16, 2021
Follows up ruflin#1898
reedy
added a commit
to reedy/Elastica
that referenced
this pull request
Feb 16, 2021
Follows up ruflin#1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1879