-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8.0 #1794
Support PHP 8.0 #1794
Conversation
acae5c8
to
a3b2289
Compare
db3fd26
to
7b89de1
Compare
One failure is remaining on PHP 8.0 but it's related to aws SDK. |
@deguif Thanks for getting this started. We had in the past a similar issue with a naming conflict with the |
@deguif This will also need an update of the CHANGELOG and I wonder if we should also update the readme that it now running at least tests with PHP 8.0? |
There are definitely more similar bugs like the one that I fixed. Amazon's job is to fix that, though. I have just fixed the one that affected me. |
Also, Guzzle, a dependency of the AWS SDK is not ready for PHP 8 yet. |
Is there option to exclude the AWS part for 8.0 for now? |
Guzzle is now ready, btw. 7.2.0 supports PHP 8.0. |
This PR will allow to support PHP 8.0 in #1794 It allows to run PHPUnit **8.5** for PHP **7.2** support, but also to run PHPUnit **9.4** for versions supporting it (7.3, 7.4, 8.0) as PHP **8.0** is not supported in PHPUnit **8.5**.
|
||
ClientConfiguration::fromDsn('test:0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since PHP 8.0 RC1 a 0 port number is considered valid: See php/php-src#6152
For details see how it behaves on other PHP versions: https://3v4l.org/ZYhJc
@ruflin I think this PR is now ready. I will later update the PHP version in travis configuration to 8.0 and also remove the composer flag |
@deguif Nice! Thank you! |
Done in this PR:
Done in previous PRs:
Elastica\Query\Match
class and add a newElastica\Query\MatchQuery
class as match is now a reserved keyword. [[PHP 8.0] Deprecate Match query class and introduce MatchQuery #1799]aws/aws-sdk-php
package version to fix a bug with PHP 8.0. [[PHP 8.0] Use AWS SDK package version compatible #1798]Done in external PRs:
aws/aws-sdk-php
to be compatible with PHP 8. [https://github.com/Fixed crash on PHP 8.0 aws/aws-sdk-php#2079]elasticsearch/elasticsearch
to be compatible with PHP 8.0 and remove--ignore-platform-reqs
composer option.