Fixed crash on PHP 8.0

[GrahamCampbell]

Fixes:

Error: Unknown named parameter $env

.../vendor/aws/aws-sdk-php/src/Credentials/CredentialProvider.php:124
.../vendor/aws/aws-sdk-php/src/ClientResolver.php:473
.../vendor/aws/aws-sdk-php/src/ClientResolver.php:295
.../vendor/aws/aws-sdk-php/src/AwsClient.php:199
.../vendor/aws/aws-sdk-php/src/S3/S3Client.php:328

---

Evidence this fix is correct: https://3v4l.org/LJchL, https://3v4l.org/IBO1U.

[codecov-commenter]

Codecov Report

Merging #2079 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2079   +/-   ##
=========================================
  Coverage     93.24%   93.24%           
  Complexity     3854     3854           
=========================================
  Files           215      215           
  Lines         10411    10411           
=========================================
  Hits           9708     9708           
  Misses          703      703           

Impacted Files	Coverage Δ	Complexity Δ
src/Credentials/CredentialProvider.php	95.39% <100.00%> (ø)	150.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5651d8a...371775b. Read the comment docs.

[GrahamCampbell]

Ping @SamRemis. This is a blocker for Laravel.

[SamRemis]

Thank you for the PR @GrahamCampbell, and I apologize for the delay in looking into it. I want to be positive that this will have no customer impact. It definitely looks safe to me, but this does strip some of the key data from $defaultChain. I don't see anywhere the keys are consumed so it should be safe to accept. I need to double check; barring any new findings, it will be completed soon

[GrahamCampbell]

That's why I showed you https://3v4l.org/LJchL, https://3v4l.org/IBO1U, which proves this is safe.

[SamRemis]

Change is good, please add a changelog file and we will merge it

[SamRemis]

@GrahamCampbell I tried pushing it myself, but the repo denied permission. To add the changelog file, add the below contents to a file under .changes/nextrelease/[file-name-here].json. I used '.changes/nextrelease/php-8-patch.json'.

[
{
"type": "bugfix",
"category": "Credentials",
"description": "Fixes a crash in PHP 8.0 by calling array_values on the default chain array passed into self::chain"
}
]

[GrahamCampbell]

You do (already) have permission to push to my branch, however the PR probably needs rebasing. Feel free to take it over, or just cherry-pick my commit.

[deguif]

Any status about this fix?

[GrahamCampbell]

Just rebased this and added the nextrelease entry.