Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure visibility_required CS rule for constants #1723

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Configure visibility_required CS rule for constants #1723

merged 3 commits into from
Dec 4, 2019

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Dec 3, 2019

No description provided.

ruflin
ruflin approved these changes Dec 4, 2019
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So in summary: All constants default to public except the testing one default to private, correct. That makes sense 👍

@ruflin ruflin merged commit e09439b into ruflin:master Dec 4, 2019
@deguif deguif deleted the constant-visibility branch December 4, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deguif @ruflin