Configure visibility_required CS rule for constants (#1723)

.php_cs.dist

@@ -21,6 +21,7 @@ $config = PhpCsFixer\Config::create()
         'native_function_invocation' => true,
         'no_alias_functions' => true,
         'nullable_type_declaration_for_default_null_value' => true,
+        'visibility_required' => ['property', 'method', 'const'],
     ])
 ;
 

CHANGELOG.md

@@ -24,6 +24,7 @@ All notable changes to this project will be documented in this file based on the
 
 * Launch tests with PHP 7.4
 * Added `nullable_type_declaration_for_default_null_value`, `no_alias_functions` CS rules [#1706](https://github.com/ruflin/Elastica/pull/1706)
+* Configured `visibility_required` CS rule for constants [#1723](https://github.com/ruflin/Elastica/pull/1723)
 
 ### Deprecated
 

lib/Elastica/Aggregation/AvgBucket.php

@@ -11,8 +11,8 @@
  */
 class AvgBucket extends AbstractAggregation
 {
-    const DEFAULT_GAP_POLICY_VALUE = 'skip';
-    const DEFAULT_FORMAT_VALUE = null;
+    public const DEFAULT_GAP_POLICY_VALUE = 'skip';
+    public const DEFAULT_FORMAT_VALUE = null;
 
     public function __construct(string $name, ?string $bucketsPath = null)
     {

lib/Elastica/Aggregation/Cardinality.php

@@ -9,7 +9,7 @@
  */
 class Cardinality extends AbstractSimpleAggregation
 {
-    const DEFAULT_PRECISION_THRESHOLD_VALUE = 3000;
+    public const DEFAULT_PRECISION_THRESHOLD_VALUE = 3000;
 
     /**
      * @return $this

lib/Elastica/Aggregation/DateHistogram.php

@@ -9,7 +9,7 @@
  */
 class DateHistogram extends Histogram
 {
-    const DEFAULT_TIMEZONE_VALUE = 'UTC';
+    public const DEFAULT_TIMEZONE_VALUE = 'UTC';
 
     /**
      * Set time_zone option.

lib/Elastica/Aggregation/Filters.php

@@ -12,8 +12,8 @@
  */
 class Filters extends AbstractAggregation
 {
-    const NAMED_TYPE = 1;
-    const ANONYMOUS_TYPE = 2;
+    public const NAMED_TYPE = 1;
+    public const ANONYMOUS_TYPE = 2;
 
     /**
      * @var int Type of bucket keys - named, or anonymous

lib/Elastica/Aggregation/GeoDistance.php

@@ -11,11 +11,11 @@
  */
 class GeoDistance extends AbstractAggregation
 {
-    const DISTANCE_TYPE_ARC = 'arc';
-    const DISTANCE_TYPE_PLANE = 'plane';
+    public const DISTANCE_TYPE_ARC = 'arc';
+    public const DISTANCE_TYPE_PLANE = 'plane';
 
-    const DEFAULT_DISTANCE_TYPE_VALUE = self::DISTANCE_TYPE_ARC;
-    const DEFAULT_UNIT_VALUE = 'm';
+    public const DEFAULT_DISTANCE_TYPE_VALUE = self::DISTANCE_TYPE_ARC;
+    public const DEFAULT_UNIT_VALUE = 'm';
 
     /**
      * @param string       $name   the name if this aggregation

lib/Elastica/Aggregation/GeohashGrid.php

@@ -9,8 +9,8 @@
  */
 class GeohashGrid extends AbstractAggregation
 {
-    const DEFAULT_PRECISION_VALUE = 5;
-    const DEFAULT_SIZE_VALUE = 10000;
+    public const DEFAULT_PRECISION_VALUE = 5;
+    public const DEFAULT_SIZE_VALUE = 10000;
 
     /**
      * @param string $name  the name of this aggregation

lib/Elastica/Aggregation/SerialDiff.php

@@ -11,7 +11,7 @@
  */
 class SerialDiff extends AbstractAggregation
 {
-    const DEFAULT_GAP_POLICY_VALUE = 'insert_zero';
+    public const DEFAULT_GAP_POLICY_VALUE = 'insert_zero';
 
     public function __construct(string $name, ?string $bucketsPath = null)
     {

lib/Elastica/Bulk.php

@@ -13,7 +13,7 @@
 
 class Bulk
 {
-    const DELIMITER = "\n";
+    public const DELIMITER = "\n";
 
     /**
      * @var Client

lib/Elastica/Bulk/Action.php

@@ -8,10 +8,10 @@
 
 class Action
 {
-    const OP_TYPE_CREATE = 'create';
-    const OP_TYPE_INDEX = 'index';
-    const OP_TYPE_DELETE = 'delete';
-    const OP_TYPE_UPDATE = 'update';
+    public const OP_TYPE_CREATE = 'create';
+    public const OP_TYPE_INDEX = 'index';
+    public const OP_TYPE_DELETE = 'delete';
+    public const OP_TYPE_UPDATE = 'update';
 
     /**
      * @var array

lib/Elastica/Connection.php

@@ -15,39 +15,39 @@ class Connection extends Param
     /**
      * Default elastic search port.
      */
-    const DEFAULT_PORT = 9200;
+    public const DEFAULT_PORT = 9200;
 
     /**
      * Default host.
      */
-    const DEFAULT_HOST = 'localhost';
+    public const DEFAULT_HOST = 'localhost';
 
     /**
      * Default transport.
      *
      * @var string
      */
-    const DEFAULT_TRANSPORT = 'Http';
+    public const DEFAULT_TRANSPORT = 'Http';
 
     /**
      * Default compression.
      *
      * @var string
      */
-    const DEFAULT_COMPRESSION = false;
+    public const DEFAULT_COMPRESSION = false;
 
     /**
      * Number of seconds after a timeout occurs for every request
      * If using indexing of file large value necessary.
      */
-    const TIMEOUT = 300;
+    public const TIMEOUT = 300;
 
     /**
      * Number of seconds after a connection timeout occurs for every request during the connection phase.
      *
      * @see Connection::setConnectTimeout();
      */
-    const CONNECT_TIMEOUT = 0;
+    public const CONNECT_TIMEOUT = 0;
 
     /**
      * Creates a new connection object. A connection is enabled by default.

lib/Elastica/Exception/ElasticsearchException.php

@@ -11,7 +11,7 @@
  */
 class ElasticsearchException extends \Exception implements ExceptionInterface
 {
-    const REMOTE_TRANSPORT_EXCEPTION = 'RemoteTransportException';
+    public const REMOTE_TRANSPORT_EXCEPTION = 'RemoteTransportException';
 
     /**
      * @var string|null Elasticsearch exception name

lib/Elastica/Index/Settings.php

@@ -22,11 +22,11 @@
  */
 class Settings
 {
-    const DEFAULT_REFRESH_INTERVAL = '1s';
+    public const DEFAULT_REFRESH_INTERVAL = '1s';
 
-    const DEFAULT_NUMBER_OF_REPLICAS = 1;
+    public const DEFAULT_NUMBER_OF_REPLICAS = 1;
 
-    const DEFAULT_NUMBER_OF_SHARDS = 1;
+    public const DEFAULT_NUMBER_OF_SHARDS = 1;
 
     /**
      * Response.

lib/Elastica/Processor/Attachment.php

@@ -11,9 +11,9 @@
  */
 class Attachment extends AbstractProcessor
 {
-    const DEFAULT_TARGET_FIELD_VALUE = 'attachment';
-    const DEFAULT_INDEXED_CHARS_VALUE = 100000;
-    const DEFAULT_IGNORE_MISSING_VALUE = false;
+    public const DEFAULT_TARGET_FIELD_VALUE = 'attachment';
+    public const DEFAULT_INDEXED_CHARS_VALUE = 100000;
+    public const DEFAULT_IGNORE_MISSING_VALUE = false;
 
     /**
      * Attachment constructor.

lib/Elastica/Processor/Convert.php

@@ -11,8 +11,8 @@
  */
 class Convert extends AbstractProcessor
 {
-    const DEFAULT_TARGET_FIELD_VALUE = 'field';
-    const DEFAULT_IGNORE_MISSING_VALUE = false;
+    public const DEFAULT_TARGET_FIELD_VALUE = 'field';
+    public const DEFAULT_IGNORE_MISSING_VALUE = false;
 
     /**
      * Convert constructor.

lib/Elastica/Processor/Date.php

@@ -11,9 +11,9 @@
  */
 class Date extends AbstractProcessor
 {
-    const DEFAULT_TARGET_FIELD_VALUE = '@timestamp';
-    const DEFAULT_TIMEZONE_VALUE = 'UTC';
-    const DEFAULT_LOCALE_VALUE = 'ENGLISH';
+    public const DEFAULT_TARGET_FIELD_VALUE = '@timestamp';
+    public const DEFAULT_TIMEZONE_VALUE = 'UTC';
+    public const DEFAULT_LOCALE_VALUE = 'ENGLISH';
 
     /**
      * Date constructor.

lib/Elastica/Processor/DateIndexName.php

@@ -11,10 +11,10 @@
  */
 class DateIndexName extends AbstractProcessor
 {
-    const DEFAULT_DATE_FORMATS_VALUE = ['ISO8601'];
-    const DEFAULT_INDEX_NAME_FORMAT_VALUE = 'yyyy-MM-dd';
-    const DEFAULT_TIMEZONE_VALUE = 'UTC';
-    const DEFAULT_LOCALE_VALUE = 'ENGLISH';
+    public const DEFAULT_DATE_FORMATS_VALUE = ['ISO8601'];
+    public const DEFAULT_INDEX_NAME_FORMAT_VALUE = 'yyyy-MM-dd';
+    public const DEFAULT_TIMEZONE_VALUE = 'UTC';
+    public const DEFAULT_LOCALE_VALUE = 'ENGLISH';
 
     /**
      * DateIndexName constructor.

lib/Elastica/Processor/Json.php

@@ -11,8 +11,8 @@
  */
 class Json extends AbstractProcessor
 {
-    const DEFAULT_TARGET_FIELD_VALUE = 'field';
-    const DEFAULT_ADD_TO_ROOT_VALUE = false;
+    public const DEFAULT_TARGET_FIELD_VALUE = 'field';
+    public const DEFAULT_ADD_TO_ROOT_VALUE = false;
 
     /**
      * Json constructor.

lib/Elastica/Processor/Kv.php

@@ -11,8 +11,8 @@
  */
 class Kv extends AbstractProcessor
 {
-    const DEFAULT_TARGET_FIELD_VALUE = null;
-    const DEFAULT_IGNORE_MISSING_VALUE = false;
+    public const DEFAULT_TARGET_FIELD_VALUE = null;
+    public const DEFAULT_IGNORE_MISSING_VALUE = false;
 
     /**
      * Kv constructor.

lib/Elastica/Processor/Rename.php

@@ -11,7 +11,7 @@
  */
 class Rename extends AbstractProcessor
 {
-    const DEFAULT_IGNORE_MISSING_VALUE = false;
+    public const DEFAULT_IGNORE_MISSING_VALUE = false;
 
     /**
      * Rename constructor.

lib/Elastica/Processor/Set.php

@@ -11,7 +11,7 @@
  */
 class Set extends AbstractProcessor
 {
-    const DEFAULT_OVERRIDE_VALUE = true;
+    public const DEFAULT_OVERRIDE_VALUE = true;
 
     /**
      * Set constructor.

lib/Elastica/Processor/Sort.php

@@ -11,7 +11,7 @@
  */
 class Sort extends AbstractProcessor
 {
-    const DEFAULT_ORDER_VALUE = 'asc';
+    public const DEFAULT_ORDER_VALUE = 'asc';
 
     /**
      * Sort constructor.

lib/Elastica/Processor/Split.php

@@ -11,7 +11,7 @@
  */
 class Split extends AbstractProcessor
 {
-    const DEFAULT_IGNORE_MISSING_VALUE = false;
+    public const DEFAULT_IGNORE_MISSING_VALUE = false;
 
     /**
      * Split constructor.

lib/Elastica/Query/AbstractGeoDistance.php

@@ -13,8 +13,8 @@
  */
 abstract class AbstractGeoDistance extends AbstractQuery
 {
-    const LOCATION_TYPE_GEOHASH = 'geohash';
-    const LOCATION_TYPE_LATLON = 'latlon';
+    public const LOCATION_TYPE_GEOHASH = 'geohash';
+    public const LOCATION_TYPE_LATLON = 'latlon';
 
     /**
      * Location type.

lib/Elastica/Query/AbstractGeoShape.php

@@ -12,16 +12,16 @@
 abstract class AbstractGeoShape extends AbstractQuery
 {
     /** Return all documents whose geo_shape field intersects the query geometry. (default behavior) */
-    const RELATION_INTERSECT = 'intersects';
+    public const RELATION_INTERSECT = 'intersects';
 
     /** Return all documents whose geo_shape field has nothing in common with the query geometry. */
-    const RELATION_DISJOINT = 'disjoint';
+    public const RELATION_DISJOINT = 'disjoint';
 
     /** Return all documents whose geo_shape field is within the query geometry. */
-    const RELATION_WITHIN = 'within';
+    public const RELATION_WITHIN = 'within';
 
     /** Return all documents whose geo_shape field contains the query geometry. */
-    const RELATION_CONTAINS = 'contains';
+    public const RELATION_CONTAINS = 'contains';
 
     /**
      * Elasticsearch path of the geo_shape field.

lib/Elastica/Query/Boosting.php

@@ -11,7 +11,7 @@
  */
 class Boosting extends AbstractQuery
 {
-    const NEGATIVE_BOOST = 0.2;
+    public const NEGATIVE_BOOST = 0.2;
 
     /**
      * Set the positive query for this Boosting Query.

lib/Elastica/Query/Common.php

@@ -9,8 +9,8 @@
  */
 class Common extends AbstractQuery
 {
-    const OPERATOR_AND = 'and';
-    const OPERATOR_OR = 'or';
+    public const OPERATOR_AND = 'and';
+    public const OPERATOR_OR = 'or';
 
     /**
      * @var string