Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose getNumberOfReplicas() from index settings #1324

Merged
merged 2 commits into from
Jun 13, 2017
Merged

Expose getNumberOfReplicas() from index settings #1324

merged 2 commits into from
Jun 13, 2017

Conversation

thePanz
Copy link
Collaborator

@thePanz thePanz commented Jun 8, 2017 •
edited
Loading

The index settings exposes most of the available settings, while for the numberOfReplicas the "get" method is missing

@ruflin
Copy link
Owner

ruflin commented Jun 13, 2017

LGTM. Could you add a changelog entry?

@thePanz thePanz changed the title Expose getNumberOfReplicas() from index settings WIP: Expose getNumberOfReplicas() from index settings Jun 13, 2017
@thePanz
Copy link
Collaborator Author

thePanz commented Jun 13, 2017

@ruflin Changelog added, plus:

  • fixed a typo in the test name (it was "shards" instead of "replicas")
  • removed usage of empty, as we can set 0 (zero) replicas

@ruflin ruflin merged commit 464899a into ruflin:master Jun 13, 2017
@ruflin
Copy link
Owner

ruflin commented Jun 13, 2017

Thanks, merged.

@thePanz thePanz changed the title WIP: Expose getNumberOfReplicas() from index settings Expose getNumberOfReplicas() from index settings Jun 13, 2017
@thePanz thePanz deleted the expose-settings-get-number-of-replicas branch June 13, 2017 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thePanz @ruflin