Expose getNumberOfReplicas() from index settings (#1324)

The index settings exposes most of the available settings, while for the numberOfReplicas the "get" method is missing

CHANGELOG.md

@@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file based on the
 - Send the `scroll_id` inside a json body instead of plain text [#1325](https://github.com/ruflin/Elastica/pull/1325)
 
 ### Added
+ - Added getNumberOfReplicas() for index settings [PR#1324](https://github.com/ruflin/Elastica/pull/1324)
 
 ### Improvements
 

lib/Elastica/Index/Settings.php

@@ -22,6 +22,8 @@ class Settings
 {
     const DEFAULT_REFRESH_INTERVAL = '1s';
 
+    const DEFAULT_NUMBER_OF_REPLICAS = 1;
+
     /**
      * Response.
      *
@@ -133,6 +135,24 @@ public function setNumberOfReplicas($replicas)
         return $this->set(['number_of_replicas' => (int) $replicas]);
     }
 
+    /**
+     * Returns the number of replicas.
+     *
+     * If no number of replicas is set, the default number is returned
+     *
+     * @return int The number of replicas
+     */
+    public function getNumberOfReplicas()
+    {
+        $replicas = $this->get('number_of_replicas');
+
+        if (null === $replicas) {
+            $replicas = self::DEFAULT_NUMBER_OF_REPLICAS;
+        }
+
+        return $replicas;
+    }
+
     /**
      * Sets the index to read only.
      *

test/Elastica/Index/SettingsTest.php

@@ -59,7 +59,7 @@ public function testGetWithAlias()
     /**
      * @group functional
      */
-    public function testSetNumberOfReplicas()
+    public function testSetGetNumberOfReplicas()
     {
         $indexName = 'test';
 
@@ -68,13 +68,37 @@ public function testSetNumberOfReplicas()
         $index->create([], true);
         $settings = $index->getSettings();
 
-        $settings->setNumberOfReplicas(2);
+        // Check for zero replicas
+        $settings->setNumberOfReplicas(0);
         $index->refresh();
-        $this->assertEquals(2, $settings->get('number_of_replicas'));
+        $this->assertEquals(0, $settings->get('number_of_replicas'));
+        $this->assertEquals(0, $settings->getNumberOfReplicas());
 
+        // Check with 3 replicas
         $settings->setNumberOfReplicas(3);
         $index->refresh();
         $this->assertEquals(3, $settings->get('number_of_replicas'));
+        $this->assertEquals(3, $settings->getNumberOfReplicas());
+
+        $index->delete();
+    }
+
+    /**
+     * @group functional
+     */
+    public function testGetNumberOfReplicas()
+    {
+        $indexName = 'test';
+
+        $client = $this->_getClient();
+        $index = $client->getIndex($indexName);
+        $index->create([], true);
+
+        $settings = $index->getSettings();
+
+        // Test with default number of replicas
+        $this->assertEquals(IndexSettings::DEFAULT_NUMBER_OF_REPLICAS, $settings->get('number_of_replicas'));
+        $this->assertEquals(IndexSettings::DEFAULT_NUMBER_OF_REPLICAS, $settings->getNumberOfReplicas());
 
         $index->delete();
     }