Global Aggregation #555
Merged
Global Aggregation #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw PartialShardFailureException if response has failed shards
| * @return AbstractAggregation | ||
| */ | ||
| public function addAggregation(AbstractAggregation $aggregation) | ||
| { | ||
| if(is_a($aggregation, 'Elastica\Aggregation\GlobalAggregation')) | ||
| throw new InvalidException('Global aggregators can only be placed as top level aggregators'); |
There was a problem hiding this comment.
Please always use { } also for 1 line if clauses.
There was a problem hiding this comment.
Ok no problem .. will fix that
Conflicts: changes.txt
|
Done |
|
Merged. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global aggregation is not allowed as sub aggregation - added exception
@see http://www.elasticsearch.org/guide/en/elasticsearch/reference/master/search-aggregations-bucket-global-aggregation.html