Global Aggregation

changes.txt

@@ -1,4 +1,7 @@
 CHANGES
+2014-02-17
+- Elastica/Aggregations - global aggragation not allowed as sub aggragation
+
 2014-02-14
 - Add methods setSize, setShardSize to Elastica/Aggregation/Terms
 - Elastica/Aggregation/GlobalAggregationTest fixed bug where JSON returned [] instead of {}

lib/Elastica/Aggregation/AbstractAggregation.php

@@ -2,8 +2,8 @@
 
 namespace Elastica\Aggregation;
 
-
 use Elastica\Param;
+use Elastica\Exception\InvalidException;
 
 abstract class AbstractAggregation extends Param
 {
@@ -57,10 +57,14 @@ public function getAggs()
     /**
      * Add a sub-aggregation
      * @param AbstractAggregation $aggregation
+     * @throws \Elastica\Exception\InvalidException
      * @return AbstractAggregation
      */
     public function addAggregation(AbstractAggregation $aggregation)
     {
+        if(is_a($aggregation, 'Elastica\Aggregation\GlobalAggregation'))
+            throw new InvalidException('Global aggregators can only be placed as top level aggregators');
+
         $this->_aggs[$aggregation->getName()] = $aggregation->toArray();
         return $this;
     }