-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of the new aggregation module #502
Comments
It is not planned yet but I'm sure someone will implement it if there is a need. The good part is, it will be possible to use it already from day one with the raw queries: |
work in progress here https://github.com/krzaczek/Elastica/tree/aggs |
@krzaczek Nice, looking forward to the pull request. |
@ruflin Need some help naming the "global" aggregation. Sine "global" is a restricted keyword in PHP any suggestions how I should name the "global" aggregation file and class ? Elastica/Aggregation/?.php |
Very good question. I think so far we didn't have this problem yet. Something like GlobalAgg I don't like all of them. What is your suggestion? I think it should start with Global to help with auto completion in IDE's. We could also ask elasticsearch to rename it ;-) |
Maybe GlobalBucket since it's a "global bucketing aggregation" ? |
Lets go with this one. Make sure to merge the recent changes that were made for the compatibility with 1.0.0RC1 in master. |
Already did :) |
Closed through #555 |
No description provided.
The text was updated successfully, but these errors were encountered: