Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the new aggregation module #502

Closed
revendless-team opened this issue Nov 30, 2013 · 9 comments
Closed

Implementation of the new aggregation module #502

revendless-team opened this issue Nov 30, 2013 · 9 comments

Comments

@revendless-team
Copy link

No description provided.

@ruflin
Copy link
Owner

ruflin commented Dec 1, 2013

It is not planned yet but I'm sure someone will implement it if there is a need. The good part is, it will be possible to use it already from day one with the raw queries:

http://elastica.io/example/raw-array-query.html

@krzaczek
Copy link
Contributor

work in progress here https://github.com/krzaczek/Elastica/tree/aggs

@ruflin
Copy link
Owner

ruflin commented Feb 1, 2014

@krzaczek Nice, looking forward to the pull request.

@krzaczek
Copy link
Contributor

krzaczek commented Feb 3, 2014

@ruflin Need some help naming the "global" aggregation. Sine "global" is a restricted keyword in PHP any suggestions how I should name the "global" aggregation file and class ?

http://www.elasticsearch.org/guide/en/elasticsearch/reference/master/search-aggregations-bucket-global-aggregation.html

Elastica/Aggregation/?.php

@ruflin
Copy link
Owner

ruflin commented Feb 4, 2014

Very good question. I think so far we didn't have this problem yet. Something like

GlobalAgg
GlobalA
GlobalAggregator

I don't like all of them. What is your suggestion? I think it should start with Global to help with auto completion in IDE's. We could also ask elasticsearch to rename it ;-)

@krzaczek
Copy link
Contributor

krzaczek commented Feb 4, 2014

Maybe GlobalBucket since it's a "global bucketing aggregation" ?

@ruflin
Copy link
Owner

ruflin commented Feb 5, 2014

Lets go with this one.

Make sure to merge the recent changes that were made for the compatibility with 1.0.0RC1 in master.

@krzaczek
Copy link
Contributor

krzaczek commented Feb 6, 2014

Already did :)

@ruflin
Copy link
Owner

ruflin commented Mar 8, 2014

Closed through #555

@ruflin ruflin closed this as completed Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants