Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 313. Unhandled response status codes in BaseEndpoint #459

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Bug 313. Unhandled response status codes in BaseEndpoint #459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c103314
Gateway error handling: add a handler for 404 status code and fix the…
MytsV Aug 15, 2024
a77bd43
Gateway error handling: produce unknown error by default
MytsV Aug 15, 2024
cdae75c
Gateway error handling: decompose the message handling and stringify …
MytsV Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 13 additions & 21 deletions src/lib/sdk/gateway-endpoints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,42 +268,34 @@ async function handleCommonGatewayEndpointErrors<TDTO extends BaseDTO>(statusCod
errorMessage: `An error occurred while fetching ${response.url}`,
} as TDTO;


switch(statusCode) {
case 400:
dto.errorName = BaseHttpErrorTypes.NOT_FOUND.errorName;
dto.errorMessage = `The requested resource was not found at ${response.url}.`
try {
const message = await response.json();
dto.errorMessage += ` Error Details: ${message}`;
} catch(error) {}
dto.errorName = BaseHttpErrorTypes.BAD_REQUEST.errorName;
dto.errorMessage = `The request had invalid syntax.`
break;
case 401:
dto.errorName = BaseHttpErrorTypes.INVALID_AUTH_TOKEN.errorName;
dto.errorMessage = `The provided authentication token is invalid or has expired.`;
try {
const message = await response.json();
dto.errorMessage += ` Error Details: ${message}`;
} catch(error) {}
break;
case 404:
dto.errorName = BaseHttpErrorTypes.NOT_FOUND.errorName;
dto.errorMessage = `The requested resource was not found at ${response.url}.`
break;
case 406:
dto.errorName = BaseHttpErrorTypes.NOT_ACCEPTABLE.errorName;
dto.errorMessage = `Not Acceptable.`;
try {
const message = await response.json();
} catch(error) {}
break;
case 500:
default:
dto.errorName = BaseHttpErrorTypes.UNKNOWN_ERROR.errorName;
dto.errorMessage = `An unknown server side error occurred while fetching ${response.url}.`;
try {
const message = await response.json();
dto.errorMessage += ` Error Details: ${message}`;
} catch(error) {}
break;
default:
return undefined;
}

try {
const message = JSON.stringify(await response.json());
dto.errorMessage += ` Error Details: ${message}`;
} catch(error) {}

return dto;
}

Expand Down
Loading