Bug 313. Unhandled response status codes in BaseEndpoint #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 400 status code message Fixes rucio#313
This makes all the other possible status codes cause the API page to return a valid JSON instead of HTML that may break the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313
Moreover, it makes the message from the server be displayed correctly.
Before:
{"status":"error","id":"","name":"","rse_type":"UNKNOWN","volatile":false,"deterministic":false,"staging_area":false,"message":"The requested resource was not found at https://127.0.0.1:8081/rses/?expression=MOCK1. Error Details: [object Object]"}After:
{"status":"error","id":"","name":"","rse_type":"UNKNOWN","volatile":false,"deterministic":false,"staging_area":false,"message":"The request had invalid syntax. Error Details: {\"ExceptionClass\":\"InvalidRSEExpression\",\"ExceptionMessage\":\"RSE Expression resulted in an empty set.\"}"}P. S. I changed the BAD_REQUEST error message, but I undestand that it may sometimes signify that a resource wasn't found. Please let me know if that's okay