Add support for Object#method to the Eventable module #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, Thanks! |
clayallsopp
added a commit
that referenced
this pull request
Mar 31, 2014
Add support for Object#method to the Eventable module
This was referenced Apr 1, 2014
|
Just a heads up, RM 2.25 fixes the |
|
Thanks for the heads up, it is! https://travis-ci.org/rubymotion/BubbleWrap/builds/22304051 |
clayallsopp
added a commit
that referenced
this pull request
Apr 16, 2014
- 'bubble-wrap/http' is now deprecated and will be removed in 2.0, see #308 + `BW::UIActivityViewController` wrapper added, see #335 + `BW::NetworkIndicator` added, see #349 + `BW::Location.get_compass` & `BW::Location.get_compass_once`see #348 + `NSString#to_color` ARGB support, see #350 + `Object#method` support for `BW::Reactor`, see #359 * Prevented a possible exception when stopping `BW::Location`, see #358 * Fixed a bug when requiring just 'bubble-wrap/ui'
tutuming
pushed a commit
to tutuming/BubbleWrap
that referenced
this pull request
Apr 21, 2014
- 'bubble-wrap/http' is now deprecated and will be removed in 2.0, see rubymotion-community#308 + `BW::UIActivityViewController` wrapper added, see rubymotion-community#335 + `BW::NetworkIndicator` added, see rubymotion-community#349 + `BW::Location.get_compass` & `BW::Location.get_compass_once`see rubymotion-community#348 + `NSString#to_color` ARGB support, see rubymotion-community#350 + `Object#method` support for `BW::Reactor`, see rubymotion-community#359 * Prevented a possible exception when stopping `BW::Location`, see rubymotion-community#358 * Fixed a bug when requiring just 'bubble-wrap/ui'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I make heavy use of the Eventable module, and sometimes I find it useful to re-use some methods as events. It looks similar to this:
However, Method#to_proc returns a different object each time, and this makes it difficult to unbind the event when the VC gets deallocated. This is easily solved by passing a simple Method object
My implementation is backwards compatible with the existing one so it shouldn't cause any problem to existing apps.
Also, be aware that the current test suite fails, as Object#method leaks. This bug has been reported and will be fixed in the next RM release (http://hipbyte.myjetbrains.com/youtrack/issue/RM-456).