adds 'BW::NetworkIndicator'

[colinta]

Regarding #263 and #171, I agree w/ @clayallsopp that UIApplication.sharedApplication.networkActivityIndicatorVisible should be controlled by a centralized module.

I didn't call it BW::HTTP::NetworkIndicator, because I think it could be used as a standalone module (maybe they're not using BW::HTTP).

methods available:

• BW::NetworkIndicator.show
• BW::NetworkIndicator.hide
• BW::NetworkIndicator.visible?
• BW::NetworkIndicator.reset!

Specs included.

[clayallsopp]

Sweet, and I think it would also make a lot of sense to integrate with BW::HTTP

In this case, thread safety is a realistic consideration - did you check out @bogardon's implementation or other iOS network indicator implementations? (SDNetworkActivityIndicator, AFNetworkingActivityIndicatorManager, etc)

Also the tests failed on Travis?

[colinta]

Ah, those failures are from the HTTP integration actually. I'll check it out.

I'll see what needs to be done about thread safety, too. Thanks Clay!

[clayallsopp]

Ah gotcha. Yeah, I think the networking indicator should be included by default w/ bubble-wrap/http (https://github.com/rubymotion/BubbleWrap/blob/master/lib/bubble-wrap/http.rb), instead of making the remember to require it manually

[colinta]

Man, turns out all the queries that get created in query_spec kind of throw a wrench in things; they all have to be properly cancel-ed at the end of each test, otherwise the indicator 'counter' is thrown off.

I've added a warning message to query_spec.rb that should detect if a query wasn't canceled, and ask the dev to fix the spec.

[colinta]

Dang it. Specs pass locally, I'll see what's up.

[markrickert]

@colinta It could be that the iOS version is passing and the mac version is not. See @clayallsopp's recommendation for me that helped the specs pass: #335 (comment)

[colinta]

Yeah i think you're right; getting 'cancel called on nil' when running on osx. thanks for the heads up! 😃

[colinta]

I'm still getting a 'failure' on osx, but it's in the NSIndexPathWrap methods.

NSIndexPathWrap
  - should be able to use an array like accessor
 [ERROR: NoMethodError - undefined method `indexAtPosition' for 826:Fixnum]
  - should support the each iterator
 [ERROR: NoMethodError - undefined method `length' for 826:Fixnum]

[colinta]

Strange behavior on my machine, but specs are passing on travis. :-/

[colinta]

Can someone run

rake spec osx=1 files=spec/motion/core/ns_index_path_spec.rb

and see what it says?

[clayallsopp]

This is interesting, and broken for me on master. Adding some logging, I see @index: #<ImmediateRef:0x7fcd4bd07560>, self: 0+826i

Travis runs 10.8, which could be making a difference. Sounds like a rubymotion bug @colinta? I've opened #351 and submitted a motion support ticket (#1668)

that aside, I'm down for merging this if it's okay with you @colinta?

[colinta]

Yeah, the error isn't related to the NetworkIndicator stuff, so makes sense to me! I'll keep tabs on the NSIndexPath stuff.