Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec: config.disable_monkey_patching! #211

Merged
1 commit merged into from
Dec 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/concurrency_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe "gemstash concurrency tests" do
RSpec.describe "gemstash concurrency tests" do
let(:timeout) { 5 }

def write_thread(resource_id, content = "unchanging")
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/authorization_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::Authorization do
RSpec.describe Gemstash::Authorization do
describe "#remove" do
context "with an existing authoriation" do
before do
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/cli/authorize_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
require "securerandom"
require "yaml"

describe Gemstash::CLI::Authorize do
RSpec.describe Gemstash::CLI::Authorize do
before do
# Don't let the environment change, else we get a separate test db
# connection, which messes up the tests
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/cli/base_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::CLI::Base do
RSpec.describe Gemstash::CLI::Base do
let(:cli) do
result = double(say: nil)
allow(result).to receive(:set_color) {|x| x }
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/cli/setup_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require "spec_helper"
require "yaml"

describe Gemstash::CLI::Setup do
RSpec.describe Gemstash::CLI::Setup do
let(:cli) do
result = double(options: cli_options, say: nil)
allow(result).to receive(:set_color) {|x| x }
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/configuration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::Configuration do
RSpec.describe Gemstash::Configuration do
let(:config_dir) { config_path("configuration_spec") }

context "no config file" do
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/dependencies_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::Dependencies do
RSpec.describe Gemstash::Dependencies do
let(:upstream) { "https://rubygems.org" }
let(:http_client) { double }
let(:web_deps) { Gemstash::Dependencies.for_upstream(upstream, http_client) }
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/env_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::Env do
RSpec.describe Gemstash::Env do
context ".log_file" do
let(:dir) { __dir__ }

Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/gem_pusher_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require "spec_helper"
require "zlib"

describe Gemstash::GemPusher do
RSpec.describe Gemstash::GemPusher do
let(:auth) { Gemstash::ApiKeyAuthorization.new(auth_key) }
let(:auth_with_invalid_auth_key) { Gemstash::ApiKeyAuthorization.new(invalid_auth_key) }
let(:auth_without_permission) { Gemstash::ApiKeyAuthorization.new(auth_key_without_permission) }
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/gem_source_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require "spec_helper"
require "cgi"

describe Gemstash::GemSource do
RSpec.describe Gemstash::GemSource do
let(:app) { double }
let(:middleware) { Gemstash::GemSource::RackMiddleware.new(app) }

Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/gem_yanker_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::GemYanker do
RSpec.describe Gemstash::GemYanker do
let(:auth) { Gemstash::ApiKeyAuthorization.new(auth_key) }
let(:auth_with_invalid_auth_key) { Gemstash::ApiKeyAuthorization.new(invalid_auth_key) }
let(:auth_without_permission) { Gemstash::ApiKeyAuthorization.new(auth_key_without_permission) }
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/http_client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::HTTPClient do
RSpec.describe Gemstash::HTTPClient do
before(:all) do
@server = SimpleServer.new("localhost")
@other_server = SimpleServer.new("127.0.0.1")
Expand Down
4 changes: 2 additions & 2 deletions spec/gemstash/logging_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::Logging do
RSpec.describe Gemstash::Logging do
it "builds a logger in the right place" do
expect(File.exist?(TEST_LOG_FILE)).to be_truthy
end
Expand All @@ -20,7 +20,7 @@
end
end

describe Gemstash::Logging::StreamLogger do
RSpec.describe Gemstash::Logging::StreamLogger do
let(:logger) { Gemstash::Logging::StreamLogger.new(Logger::INFO) }
let(:error_logger) { Gemstash::Logging::StreamLogger.new(Logger::ERROR) }

Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/rack_env_rewriter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require "spec_helper"
require "cgi"

describe Gemstash::RackEnvRewriter do
RSpec.describe Gemstash::RackEnvRewriter do
context "with just a prefix to drop" do
let(:env) do
{
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/specs_builder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::SpecsBuilder do
RSpec.describe Gemstash::SpecsBuilder do
let(:auth) { Gemstash::ApiKeyAuthorization.new(auth_key) }
let(:auth_with_invalid_auth_key) { Gemstash::ApiKeyAuthorization.new(invalid_auth_key) }
let(:auth_without_permission) { Gemstash::ApiKeyAuthorization.new(auth_key_without_permission) }
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/storage_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require "spec_helper"
require "yaml"

describe Gemstash::Storage do
RSpec.describe Gemstash::Storage do
before do
@folder = Dir.mktmpdir
end
Expand Down
4 changes: 2 additions & 2 deletions spec/gemstash/upstream_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash::Upstream do
RSpec.describe Gemstash::Upstream do
it "parses an escaped uri" do
upstream_uri = Gemstash::Upstream.new("https%3A%2F%2Frubygems.org%2F")
expect(upstream_uri.to_s).to eq("https://rubygems.org/")
Expand Down Expand Up @@ -94,7 +94,7 @@
end
end

describe Gemstash::Upstream::GemName do
RSpec.describe Gemstash::Upstream::GemName do
context "With a simple upstream" do
let(:upstream) { Gemstash::Upstream.new("https://rubygems.org/") }

Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash/web_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
require "fileutils"
require "rack/test"

describe Gemstash::Web do
RSpec.describe Gemstash::Web do
include Rack::Test::Methods

let(:http_client_builder) do
Expand Down
2 changes: 1 addition & 1 deletion spec/gemstash_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "spec_helper"

describe Gemstash do
RSpec.describe Gemstash do
it "has a version number" do
expect(Gemstash::VERSION).not_to be nil
end
Expand Down
2 changes: 1 addition & 1 deletion spec/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
require "net/http"
require "uri"

describe "gemstash integration tests" do
RSpec.describe "gemstash integration tests" do
let(:auth) { Gemstash::ApiKeyAuthorization.new(auth_key) }
let(:auth_key) { "test-key" }

Expand Down
2 changes: 2 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
Sequel::Model.db = TEST_DB

RSpec.configure do |config|
config.disable_monkey_patching!

config.around(:each) do |example|
test_env.config = TEST_CONFIG unless test_env.config == TEST_CONFIG

Expand Down