-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSpec: config.disable_monkey_patching! #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronzdoc
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTm
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 10, 2018
211: RSpec: config.disable_monkey_patching! r=bronzdoc a=olleolleolle This PR configures RSpec to avoid some now-unnecessary metaprogramming. See http://rspec.info/documentation/3.8/rspec-core/RSpec/Core/Configuration.html#disable_monkey_patching!-instance_method > Enables zero monkey patching mode for RSpec. It removes monkey patching of the top-level DSL methods (describe, shared_examples_for, etc) onto main and Module, instead requiring you to prefix these methods with RSpec.. It enables expect-only syntax for rspec-mocks and rspec-expectations. It simply disables monkey patching on whatever pieces of RSpec the user is using. Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Build succeeded |
phanle
pushed a commit
to Gusto/gemstash-public-fork-archive
that referenced
this pull request
Aug 12, 2019
200: Update rake requirement from ~> 10.0 to ~> 12.3 r=bronzdoc a=dependabot[bot] Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. <details> <summary>Changelog</summary> *Sourced from [rake's changelog](https://github.com/ruby/rake/blob/master/History.rdoc).* > === 12.3.1 > > ==== Bug fixes > > * Support did_you_mean >= v1.2.0 which has a breaking change on formatters. > Pull request [rubygems#262](https://github-redirect.dependabot.com/ruby/rake/issues/262) by FUJI Goro. > > ==== Enhancements: > > * Don't run task if it depends on already invoked but failed task. > Pull request [rubygems#252](https://github-redirect.dependabot.com/ruby/rake/issues/252) by Gonzalo Rodriguez. > * Make space trimming consistent for all task arguments. > Pull request [rubygems#259](https://github-redirect.dependabot.com/ruby/rake/issues/259) by Gonzalo Rodriguez. > * Removes duplicated inclusion of Rake::DSL in tests. > Pull request [rubygems#254](https://github-redirect.dependabot.com/ruby/rake/issues/254) by Gonzalo Rodriguez. > * Re-raise a LoadError that didn't come from require in the test loader. > Pull request [rubygems#250](https://github-redirect.dependabot.com/ruby/rake/issues/250) by Dylan Thacker-Smith. > > === 12.3.0 > > ==== Compatibility Changes > > * Bump `required_ruby_version` to Ruby 2.0.0. Rake has already > removed support for Ruby 1.9.x. > > ==== Enhancements: > > * Support `test-bundled-gems` task on ruby core. > > === 12.2.1 > > ==== Bug fixes > > * Fixed to break Capistrano::Application on capistrano3. > > === 12.2.0 > > ==== Enhancements: > > * Make rake easier to use as a library > Pull request [rubygems#211](https://github-redirect.dependabot.com/ruby/rake/issues/211) by [**drbrain**](https://github.com/drbrain) > * Fix quadratic performance in FileTask#out_of_date? > Pull request [rubygems#224](https://github-redirect.dependabot.com/ruby/rake/issues/224) by [**doudou**](https://github.com/doudou) > * Clarify output when printing nested exception traces > Pull request [rubygems#232](https://github-redirect.dependabot.com/ruby/rake/issues/232) by [**urbanautomaton**](https://github.com/urbanautomaton) > > ==== Bug fixes > > * Account for a file that match 2 or more patterns. > Pull request [rubygems#231](https://github-redirect.dependabot.com/ruby/rake/issues/231) by [**styd**](https://github.com/styd) ></table> ... (truncated) </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/ruby/rake/commits/v12.3.1) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot[bot] <support@dependabot.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures RSpec to avoid some now-unnecessary metaprogramming.
See http://rspec.info/documentation/3.8/rspec-core/RSpec/Core/Configuration.html#disable_monkey_patching!-instance_method