This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Don't call File.realpath in a loop, single call does what we want #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @bundlerbot r+ |
|
@bundlerbot r+ |
|
📌 Commit 10b98e7 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jul 29, 2018
Don't call File.realpath in a loop, single call does what we want ### What was the end-user problem that led to this PR? We're calling `File.realpath` in a loop ### What was your diagnosis of the problem? Single call already resolves symlinks recursively ### What is your fix for the problem, implemented in this PR? Drop call in a loop
|
☀️ Test successful - status-travis |
colby-swandale
pushed a commit
that referenced
this pull request
Aug 16, 2018
Don't call File.realpath in a loop, single call does what we want ### What was the end-user problem that led to this PR? We're calling `File.realpath` in a loop ### What was your diagnosis of the problem? Single call already resolves symlinks recursively ### What is your fix for the problem, implemented in this PR? Drop call in a loop (cherry picked from commit 42c4609)
colby-swandale
added a commit
that referenced
this pull request
Aug 22, 2018
* 1-16-stable: Version 1.16.4 with changelog Auto merge of #6668 - eregon:fix-encoding-spec-from-6661, r=deivid-rodriguez Add encoding magic comment to gemfile spec Auto merge of #6662 - bundler:indirect/update-authors, r=colby-swandale Auto merge of #6650 - greysteil:dont-mutate-original-trees, r=segiddins Auto merge of #6661 - eregon:consistent-encoding-for-reading-files, r=deivid-rodriguez Auto merge of #6652 - bundler:seg-molinillo-0.6.6, r=segiddins Auto merge of #6645 - bundler:colby/require-etc, r=colby-swandale Auto merge of #6636 - ojab:1-16-stable, r=indirect Auto merge of #6624 - bundler:no-document, r=colby-swandale Auto merge of #6621 - ralphbolo:patch-1, r=segiddins Auto merge of #6613 - kemitchell:mention-show-sorts-in-doc, r=colby-swandale Auto merge of #6570 - akihiro17:prerelease-dependency, r=segiddins Auto merge of #6568 - greysteil:conservative-groups, r=segiddins
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
We're calling
File.realpathin a loopWhat was your diagnosis of the problem?
Single call already resolves symlinks recursively
What is your fix for the problem, implemented in this PR?
Drop call in a loop