Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Document that bundle show [--paths] sorts results #6613

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

kemitchell
Copy link
Contributor

What was the end-user problem that led to this PR?

The problem was that I could not tell from the manpage or documentation website whether bundle show and bundle show --paths would list gems and gem paths in the same order.

I am using bundle show and bundle show --paths to inventory gems that projects depend upon.

What was your diagnosis of the problem?

My diagnosis was that the implementation of bundle show does sort results by name, but that the manpage for the subcommand doesn't mention this.

What is your fix for the problem, implemented in this PR?

My fix involved slightly editing the existing manpage for bundle show.

Why did you choose this fix out of the possible options?

I chose this fix because the .ronn file text matched the current text I was seeing via the documentation website.

@ghost
Copy link

ghost commented Jun 30, 2018

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

@kemitchell
Copy link
Contributor Author

I forgot to link to the code lines that show sorting being done.

Here is the line for --paths: https://github.com/bundler/bundler/blob/56c5c119b537ce8fc2227984a9e7a2d7b00b32c1/lib/bundler/cli/show.rb#L34

Here is the line without --paths: https://github.com/bundler/bundler/blob/56c5c119b537ce8fc2227984a9e7a2d7b00b32c1/lib/bundler/cli/show.rb#L39

@colby-swandale
Copy link
Member

Thanks! @bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 601ae64 has been approved by colby-swandale

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 601ae64 with merge 3a54aa9...

bundlerbot added a commit that referenced this pull request Jul 1, 2018
…wandale

Document that `bundle show [--paths]` sorts results

### What was the end-user problem that led to this PR?

The problem was that I could not tell from the manpage or documentation website whether `bundle show` and `bundle show --paths` would list gems and gem paths in the same order.

I am using `bundle show` and `bundle show --paths` to inventory gems that projects depend upon.

### What was your diagnosis of the problem?

My diagnosis was that the implementation of `bundle show` _does_ sort results by name, but that the manpage for the subcommand doesn't mention this.

### What is your fix for the problem, implemented in this PR?

My fix involved slightly editing the existing manpage for `bundle show`.

### Why did you choose this fix out of the possible options?

I chose this fix because the `.ronn` file text matched the current text I was seeing via the documentation website.
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: colby-swandale
Pushing 3a54aa9 to master...

@bundlerbot bundlerbot merged commit 601ae64 into rubygems:master Jul 1, 2018
@kemitchell kemitchell deleted the mention-show-sorts-in-doc branch July 1, 2018 17:48
@kemitchell
Copy link
Contributor Author

Thanks, Bundler team! The work you do is super important.

@colby-swandale colby-swandale added this to the 1.16.4 milestone Jul 17, 2018
colby-swandale pushed a commit that referenced this pull request Aug 16, 2018
…wandale

Document that `bundle show [--paths]` sorts results

### What was the end-user problem that led to this PR?

The problem was that I could not tell from the manpage or documentation website whether `bundle show` and `bundle show --paths` would list gems and gem paths in the same order.

I am using `bundle show` and `bundle show --paths` to inventory gems that projects depend upon.

### What was your diagnosis of the problem?

My diagnosis was that the implementation of `bundle show` _does_ sort results by name, but that the manpage for the subcommand doesn't mention this.

### What is your fix for the problem, implemented in this PR?

My fix involved slightly editing the existing manpage for `bundle show`.

### Why did you choose this fix out of the possible options?

I chose this fix because the `.ronn` file text matched the current text I was seeing via the documentation website.

(cherry picked from commit 3a54aa9)
colby-swandale added a commit that referenced this pull request Aug 22, 2018
* 1-16-stable:
  Version 1.16.4 with changelog
  Auto merge of #6668 - eregon:fix-encoding-spec-from-6661, r=deivid-rodriguez
  Add encoding magic comment to gemfile spec
  Auto merge of #6662 - bundler:indirect/update-authors, r=colby-swandale
  Auto merge of #6650 - greysteil:dont-mutate-original-trees, r=segiddins
  Auto merge of #6661 - eregon:consistent-encoding-for-reading-files, r=deivid-rodriguez
  Auto merge of #6652 - bundler:seg-molinillo-0.6.6, r=segiddins
  Auto merge of #6645 - bundler:colby/require-etc, r=colby-swandale
  Auto merge of #6636 - ojab:1-16-stable, r=indirect
  Auto merge of #6624 - bundler:no-document, r=colby-swandale
  Auto merge of #6621 - ralphbolo:patch-1, r=segiddins
  Auto merge of #6613 - kemitchell:mention-show-sorts-in-doc, r=colby-swandale
  Auto merge of #6570 - akihiro17:prerelease-dependency, r=segiddins
  Auto merge of #6568 - greysteil:conservative-groups, r=segiddins
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants