This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Create quality check spec for leftover debugging/development mechanisms #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| failing_lines = [] | ||
|
|
||
| File.readlines(filename).each_with_index do |line, number| | ||
| failing_lines << number + 1 if line =~ /binding\.pry/ || line =~ /sleep\s*\(?\d+/ || |
There was a problem hiding this comment.
can we collapse this into a single regexp?
|
Good call. Broke it into a more readable multi-line regex. |
|
@homu r+ |
|
📌 Commit d1eafee has been approved by |
homu
added a commit
that referenced
this pull request
May 9, 2016
…echanisms, r=segiddins Create quality check spec for leftover debugging/development mechanisms Example mechanisms that are screened for: - `sleep` - `binding.pry` - `debugger` - focused `rspec` tests via `fit` - Related to discussion at #4439 (comment)
Example mechanisms: - sleep - binding.pry - debugger - focused rspec tests via fit
|
Fixed the formatting rubocop error and re-ran the flaky Travis build job. |
|
@homu r+ |
|
📌 Commit c359410 has been approved by |
homu
added a commit
that referenced
this pull request
May 10, 2016
…echanisms, r=segiddins Create quality check spec for leftover debugging/development mechanisms Example mechanisms that are screened for: - `sleep` - `binding.pry` - `debugger` - focused `rspec` tests via `fit` - Related to discussion at #4439 (comment)
|
⚡ Test exempted - status |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example mechanisms that are screened for:
sleepbinding.prydebuggerrspectests viafit