This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Handle recursive bundle package loop when multiple gemspecs present #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gemspec = gemspec_cache_hash.values.first | ||
| root_gem_name = gemspec.name unless gemspec.nil? | ||
| gemspecs = gemspec_cache_hash.values | ||
| root_gem_names = gemspecs.map(&:name) unless gemspecs.empty? |
There was a problem hiding this comment.
the unless seems unnecessary to me?
There was a problem hiding this comment.
oh, gemspec_cache_hash.values will return an empty array if the hash is empty. Good call.
|
👍 other than the one comment |
|
Thanks for the catch. Removed the extraneous |
| gemspec :name => 'mygem' | ||
| gemspec :name => 'mygem_client' | ||
| D | ||
| sleep 10 |
There was a problem hiding this comment.
Hm, not sure how that got in since I don't think it was there on the previous iterations of this PR. Major thanks for the catch though. Think it's worth adding a spec quality check for this?
|
A quality spec that checks for focused tests, binding.pry, debugger, and sleep sounds awesome to me. :) |
|
Awesome but separate :P |
|
@homu r+ |
|
📌 Commit 762ddfa has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Apr 14, 2016
…p-with-multiple-gemspecs, r=segiddins Handle recursive bundle package loop when multiple gemspecs present `root_gem_names` should contain the names of the gems that the gemspecs in the directory are correlated with. Gems are packaged unless they're called `bundler` or their names match with the gems specified in the gemspecs. - Handles multiple gemspecs in directory - Handles case where gemspec file name does not match with the gem name specified in the gemspec - Fixes #4430
homu
added a commit
that referenced
this pull request
May 9, 2016
…echanisms, r=segiddins Create quality check spec for leftover debugging/development mechanisms Example mechanisms that are screened for: - `sleep` - `binding.pry` - `debugger` - focused `rspec` tests via `fit` - Related to discussion at #4439 (comment)
homu
added a commit
that referenced
this pull request
May 10, 2016
…echanisms, r=segiddins Create quality check spec for leftover debugging/development mechanisms Example mechanisms that are screened for: - `sleep` - `binding.pry` - `debugger` - focused `rspec` tests via `fit` - Related to discussion at #4439 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root_gem_namesshould contain the names of the gems that the gemspecs in the directory are correlated with. Gems are packaged unless they're calledbundleror their names match with the gems specified in the gemspecs.