Contributions Page Map #720
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| <template> | ||
| <section class="MapBrowser"> | ||
| <mapbox | ||
| // FIXME Pull access-token via environment variable | ||
| access-token="pk.eyJ1IjoibXV0dWFsLWFpZC1hcHAiLCJhIjoiY2tmZTBvd3UwMDBhbTJ4cDlic2JmMWZoaiJ9.rWscBjdl1SMT5N0yekIJYg" | ||
| :map-options="{ | ||
| style: 'mapbox://styles/mapbox/streets-v11', | ||
|
There was a problem hiding this comment. I don't have a strong preference for one style over another. For reference, i found this list: |
||
| center: [-75.1635262, 39.9527237], | ||
| zoom: 9, | ||
| }" | ||
| :geolocate-control="{ | ||
| show: true, | ||
| position: 'top-left', | ||
| }" | ||
| @map-load="loaded" | ||
| @map-zoomend="zoomend" | ||
| @map-click:points="clicked" | ||
| @geolocate-error="geolocateError" | ||
| @geolocate-geolocate="geolocate" | ||
| /> | ||
| </section> | ||
| </template> | ||
|
|
||
| <script> | ||
| import Mapbox from 'mapbox-gl-vue' | ||
|
There was a problem hiding this comment. Awesome, thanks for finding a vue wrapper! |
||
|
|
||
| export default { | ||
| components: { Mapbox }, | ||
| methods: { | ||
| loaded(map) { | ||
| var geojson = { | ||
| 'type': 'FeatureCollection', | ||
| 'features': [ | ||
| { | ||
| 'type': 'Feature', | ||
| 'properties': { | ||
| 'message': 'Foo', | ||
| 'icon': 'harbor', | ||
| 'iconSize': [60, 60] | ||
| }, | ||
| 'geometry': { | ||
| 'type': 'Point', | ||
| 'coordinates': [-75.1635262, 39.9527237] | ||
| } | ||
| }, | ||
| ] | ||
| } | ||
|
|
||
| map.addLayer({ | ||
| id: 'points', | ||
| type: 'symbol', | ||
| source: { | ||
| type: 'geojson', | ||
| data: geojson, | ||
| }, | ||
| layout: { | ||
| 'icon-image': '{icon}-15', | ||
| 'text-field': '{title}', | ||
| 'text-font': ['Open Sans Semibold', 'Arial Unicode MS Bold'], | ||
| 'text-offset': [0, 0.6], | ||
| 'text-anchor': 'top', | ||
| }, | ||
| }) | ||
|
|
||
| geojson.features.forEach(function (marker) { | ||
| var el = document.createElement('div'); | ||
| el.className = 'marker'; | ||
| el.style.backgroundImage = | ||
| 'url(https://placekitten.com/g/5/5/)'; | ||
| el.style.width = marker.properties.iconSize[0] + 'px'; | ||
| el.style.height = marker.properties.iconSize[1] + 'px'; | ||
|
|
||
| el.addEventListener('click', function () { | ||
| window.alert(marker.properties.message); | ||
| }); | ||
|
|
||
| new mapboxgl.Marker(el) | ||
| .setLngLat(marker.geometry.coordinates) | ||
| .addTo(map); | ||
| }); | ||
| }, | ||
| zoomend(map, e) { | ||
| console.log('Map zoomed') | ||
| }, | ||
| clicked(map, e) { | ||
| const title = e.features[0].properties.title | ||
| console.log(title) | ||
| }, | ||
| geolocateError(control, positionError) { | ||
| console.log(positionError) | ||
| }, | ||
| geolocate(control, position) { | ||
| console.log( | ||
| `User position: ${position.coords.latitude}, ${position.coords.longitude}` | ||
| ) | ||
| }, | ||
| }, | ||
| } | ||
| </script> | ||
|
|
||
| <style> | ||
| #map { | ||
| width: 100%; | ||
| height: 500px; | ||
| } | ||
| </style> | ||
|
Comment on lines
+101
to
+106
There was a problem hiding this comment. This is a great location for these styles. I don't see the There was a problem hiding this comment. yes, it's referenced from the mapbox module |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| <%= csp_meta_tag %> | ||
|
|
||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <script src='https://api.mapbox.com/mapbox-gl-js/v1.12.0/mapbox-gl.js'></script> | ||
|
There was a problem hiding this comment. There are obviously tradeoffs in both directions, but there's also the option of packaging this up with webpack: I'm good with using the cdn for now. There was a problem hiding this comment. we can circle back to this. we first tried adding it via webpack but we encountered problems. |
||
|
|
||
| <%= stylesheet_pack_tag 'application' %> | ||
| <%= javascript_pack_tag 'application' %> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"type":"FeatureCollection","query":["219","main","st","unionville","ct"],"features":[{"id":"address.2206369181761334","type":"Feature","place_type":["address"],"relevance":1,"properties":{"accuracy":"parcel"},"text":"Main Street","place_name":"219 Main Street, Unionville, Connecticut 06085, United States","center":[-72.893499,41.762479],"geometry":{"type":"Point","coordinates":[-72.893499,41.762479]},"address":"219","context":[{"id":"postcode.14464467621402050","text":"06085"},{"id":"place.13144747332333240","text":"Unionville"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.2480284386001292","type":"Feature","place_type":["address"],"relevance":0.862963,"properties":{"accuracy":"point"},"text":"Main Street","place_name":"219 Main Street, Farmington, Connecticut 06032, United States","center":[-72.840366,41.710103],"geometry":{"type":"Point","coordinates":[-72.840366,41.710103]},"address":"219","context":[{"id":"neighborhood.280951","text":"Pinnacle Heights Housing"},{"id":"postcode.13181339919821940","text":"06032"},{"id":"place.6380740233344310","wikidata":"Q743287","text":"Farmington"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.2484010684165444","type":"Feature","place_type":["address"],"relevance":0.772222,"properties":{"accuracy":"street"},"text":"Main Street","place_name":"Main Street, Unionville, Connecticut 06013, United States","center":[-72.9408282654938,41.7297867404612],"geometry":{"type":"Point","coordinates":[-72.9408282654938,41.7297867404612]},"context":[{"id":"neighborhood.279666","text":"Whigville"},{"id":"postcode.4089879986057040","text":"06013"},{"id":"place.3080439089333241","text":"Unionville"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.7817717338256888","type":"Feature","place_type":["address"],"relevance":0.725926,"properties":{"accuracy":"interpolated"},"text":"Coe Hill Road","place_name":"219 Coe Hill Road, Ctr Harbor, New Hampshire 03226, United States","matching_text":"Main Street","matching_place_name":"219 Main Street, Ctr Harbor, New Hampshire 03226, United States","center":[-71.473197,43.696059],"geometry":{"type":"Point","coordinates":[-71.473197,43.696059],"interpolated":true,"omitted":true},"address":"219","context":[{"id":"postcode.16046397562401600","text":"03226"},{"id":"place.16305096151974080","text":"Ctr Harbor"},{"id":"region.3337369023309770","wikidata":"Q759","short_code":"US-NH","text":"New Hampshire"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.772586749633468","type":"Feature","place_type":["address"],"relevance":0.658333,"properties":{"accuracy":"street"},"text":"Main Street","place_name":"Main Street, Canton, Connecticut 06019, United States","center":[-72.9210656847062,41.8109182147672],"geometry":{"type":"Point","coordinates":[-72.9210656847062,41.8109182147672]},"context":[{"id":"neighborhood.295455","text":"Collinsville"},{"id":"postcode.9417529660006990","text":"06019"},{"id":"place.7857735088607040","wikidata":"Q1033861","text":"Canton"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]}],"attribution":"NOTICE: © 2020 Mapbox and its suppliers. All rights reserved. Use of this data is subject to the Mapbox Terms of Service (https://www.mapbox.com/about/maps/). This response and the information it contains may not be retained. POI(s) provided by Foursquare."} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"type":"FeatureCollection","query":["219","main","st","unionville","ct"],"features":[{"id":"address.2206369181761334","type":"Feature","place_type":["address"],"relevance":1,"properties":{"accuracy":"parcel"},"text":"Main Street","place_name":"219 Main Street, Unionville, Connecticut 06085, United States","center":[-72.893499,41.762479],"geometry":{"type":"Point","coordinates":[-72.893499,41.762479]},"address":"219","context":[{"id":"postcode.14464467621402050","text":"06085"},{"id":"place.13144747332333240","text":"Unionville"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.2480284386001292","type":"Feature","place_type":["address"],"relevance":0.862963,"properties":{"accuracy":"point"},"text":"Main Street","place_name":"219 Main Street, Farmington, Connecticut 06032, United States","center":[-72.840366,41.710103],"geometry":{"type":"Point","coordinates":[-72.840366,41.710103]},"address":"219","context":[{"id":"neighborhood.280951","text":"Pinnacle Heights Housing"},{"id":"postcode.13181339919821940","text":"06032"},{"id":"place.6380740233344310","wikidata":"Q743287","text":"Farmington"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.2484010684165444","type":"Feature","place_type":["address"],"relevance":0.772222,"properties":{"accuracy":"street"},"text":"Main Street","place_name":"Main Street, Unionville, Connecticut 06013, United States","center":[-72.9408282654938,41.7297867404612],"geometry":{"type":"Point","coordinates":[-72.9408282654938,41.7297867404612]},"context":[{"id":"neighborhood.279666","text":"Whigville"},{"id":"postcode.4089879986057040","text":"06013"},{"id":"place.3080439089333241","text":"Unionville"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.7817717338256888","type":"Feature","place_type":["address"],"relevance":0.725926,"properties":{"accuracy":"interpolated"},"text":"Coe Hill Road","place_name":"219 Coe Hill Road, Ctr Harbor, New Hampshire 03226, United States","matching_text":"Main Street","matching_place_name":"219 Main Street, Ctr Harbor, New Hampshire 03226, United States","center":[-71.473197,43.696059],"geometry":{"type":"Point","coordinates":[-71.473197,43.696059],"interpolated":true,"omitted":true},"address":"219","context":[{"id":"postcode.16046397562401600","text":"03226"},{"id":"place.16305096151974080","text":"Ctr Harbor"},{"id":"region.3337369023309770","wikidata":"Q759","short_code":"US-NH","text":"New Hampshire"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]},{"id":"address.772586749633468","type":"Feature","place_type":["address"],"relevance":0.658333,"properties":{"accuracy":"street"},"text":"Main Street","place_name":"Main Street, Canton, Connecticut 06019, United States","center":[-72.9210656847062,41.8109182147672],"geometry":{"type":"Point","coordinates":[-72.9210656847062,41.8109182147672]},"context":[{"id":"neighborhood.295455","text":"Collinsville"},{"id":"postcode.9417529660006990","text":"06019"},{"id":"place.7857735088607040","wikidata":"Q1033861","text":"Canton"},{"id":"region.9926898961180480","wikidata":"Q779","short_code":"US-CT","text":"Connecticut"},{"id":"country.19678805456372290","wikidata":"Q30","short_code":"us","text":"United States"}]}],"attribution":"NOTICE: © 2020 Mapbox and its suppliers. All rights reserved. Use of this data is subject to the Mapbox Terms of Service (https://www.mapbox.com/about/maps/). This response and the information it contains may not be retained. POI(s) provided by Foursquare."} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably want to pull this in via an environment variable.
That'll require reading that on the server and making it available to the front end, which we don't currently have an example of (well, we have examples of getting page data into vue, but i suspect we'll want a slightly different scheme for globals such as this).
I'm ok with punting on that for now. Would you mind leaving a
FIXMEcomment in there so we come back to it (one day!).