Contributions Page Map #720
Conversation
|
@exbinary @maebeale Just some follow up questions:
|
| <style> | ||
| #map { | ||
| width: 100%; | ||
| height: 500px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
This is a great location for these styles. I don't see the #map element in the markup here, i assume that brought in by the mapbox element?
There was a problem hiding this comment.
yes, it's referenced from the mapbox module
| <template> | ||
| <section class="MapBrowser"> | ||
| <mapbox | ||
| access-token="pk.eyJ1IjoibXV0dWFsLWFpZC1hcHAiLCJhIjoiY2tmZTBvd3UwMDBhbTJ4cDlic2JmMWZoaiJ9.rWscBjdl1SMT5N0yekIJYg" |
There was a problem hiding this comment.
We'll probably want to pull this in via an environment variable.
That'll require reading that on the server and making it available to the front end, which we don't currently have an example of (well, we have examples of getting page data into vue, but i suspect we'll want a slightly different scheme for globals such as this).
I'm ok with punting on that for now. Would you mind leaving a FIXME comment in there so we come back to it (one day!).
| <mapbox | ||
| access-token="pk.eyJ1IjoibXV0dWFsLWFpZC1hcHAiLCJhIjoiY2tmZTBvd3UwMDBhbTJ4cDlic2JmMWZoaiJ9.rWscBjdl1SMT5N0yekIJYg" | ||
| :map-options="{ | ||
| style: 'mapbox://styles/mapbox/streets-v11', |
There was a problem hiding this comment.
I don't have a strong preference for one style over another. For reference, i found this list:
https://docs.mapbox.com/api/maps/#mapbox-styles
Of those, i'd be good with streets, light, satellite-streets.
Curious if others have preferences. Also easy to change, so happy to go with your suggestion.
| @@ -4,6 +4,7 @@ | |||
| <%= csp_meta_tag %> | |||
|
|
|||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | |||
| <script src='https://api.mapbox.com/mapbox-gl-js/v1.12.0/mapbox-gl.js'></script> | |||
There was a problem hiding this comment.
There are obviously tradeoffs in both directions, but there's also the option of packaging this up with webpack:
https://docs.mapbox.com/mapbox-gl-js/api/ and https://docs.mapbox.com/mapbox-gl-js/api/#mapbox-css.
I'm good with using the cdn for now.
There was a problem hiding this comment.
we can circle back to this. we first tried adding it via webpack but we encountered problems.
| </template> | ||
|
|
||
| <script> | ||
| import Mapbox from 'mapbox-gl-vue' |
There was a problem hiding this comment.
Awesome, thanks for finding a vue wrapper!
- set zoom level - set center to PHL - set empty feature collection
…to feature/mapbox
This PR adds a map button and map to the Contributions page.
References
707