Body should be non-frozen by default. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for reference, this is the original PR that introduced frozen strings #65. |
NotMyFault
pushed a commit
to jenkins-infra/jenkins.io
that referenced
this pull request
Feb 2, 2023
The PR #5971 updating to 1.8.0 had to be reverted in #5987 because of [a bug](ruby/webrick#106). Update to 1.8.1 should be safe since said bug was fixed in the last release (see ruby/webrick#103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is affecting Rack v2 which appends to the response body:
https://github.com/rack/rack/blob/cd4c9f0e4befccd53c3f03ed9af8c9a9c438d0a9/lib/rack/handler/webrick.rb#L119-L121