Update dependency webrick to '~> 1.8.0' #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
NotMyFault
approved these changes
Jan 27, 2023
MarkEWaite
added a commit
to MarkEWaite/jenkins.io
that referenced
this pull request
Jan 31, 2023
The upgrade from webrick 1.7.0 to 1.8.0 causes `make run` to report that
it cannot modify frozen strings. Page generation fails for the top
level page and for the changelog page that I was trying to check.
Exact failure message was:
```
[2023-01-31 13:24:07] INFO WEBrick 1.8.0
[2023-01-31 13:24:07] INFO ruby 3.2.0 (2022-12-25) [x86_64-linux]
[2023-01-31 13:24:07] INFO WEBrick::HTTPServer#start: pid=1 port=4242
Regenerate /home/mwaite/git/jenkins/jenkins.io/content/index.html.haml
[2023-01-31 13:24:11] ERROR FrozenError: can't modify frozen String: ""
/home/mwaite/git/jenkins/jenkins.io/vendor/gems/ruby/3.2.0/gems/rack-2.2.6.2/lib/rack/handler/webrick.rb:120:in `block in service'
/home/mwaite/git/jenkins/jenkins.io/vendor/gems/ruby/3.2.0/gems/rack-2.2.6.2/lib/rack/handler/webrick.rb:119:in `each'
/home/mwaite/git/jenkins/jenkins.io/vendor/gems/ruby/3.2.0/gems/rack-2.2.6.2/lib/rack/handler/webrick.rb:119:in `service'
/home/mwaite/git/jenkins/jenkins.io/vendor/gems/ruby/3.2.0/gems/webrick-1.8.0/lib/webrick/httpserver.rb:140:in `service'
/home/mwaite/git/jenkins/jenkins.io/vendor/gems/ruby/3.2.0/gems/webrick-1.8.0/lib/webrick/httpserver.rb:96:in `run'
/home/mwaite/git/jenkins/jenkins.io/vendor/gems/ruby/3.2.0/gems/webrick-1.8.0/lib/webrick/server.rb:310:in `block in start_thread'
/home/mwaite/git/jenkins/jenkins.io/vendor/gems/ruby/3.2.0/gems/logging-2.3.1/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'
172.16.16.185 - - [31/Jan/2023:13:24:10 UTC] "GET / HTTP/1.1" 500 333
- -> /
```
Don't want to delay availability of the weekly changelog while the
regression is investigated. Revert now, then investigation can happen
at a time that is convenient.
This reverts commit 0a7b884.
NotMyFault
pushed a commit
that referenced
this pull request
Feb 2, 2023
The PR #5971 updating to 1.8.0 had to be reverted in #5987 because of [a bug](ruby/webrick#106). Update to 1.8.1 should be safe since said bug was fixed in the last release (see ruby/webrick#103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
'~> 1.7.0'->'~> 1.8.0'Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.