Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword arguments for severity and tags in Diagnostic #290

Merged
merged 1 commit into from
Mar 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/typeprof/diagnostic.rb
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
module TypeProf
class Diagnostic
def initialize(node, meth, msg)
def initialize(node, meth, msg, severity: :error, tags: nil)
@node = node
@meth = meth
@msg = msg
@severity = :error # TODO: keyword argument
@tags = nil # TODO: keyword argument
@severity = severity
@tags = tags
end

def reuse(new_node)
@node = new_node
end

attr_reader :msg, :severity
attr_reader :msg, :severity, :tags

def code_range
@node.send(@meth)
Expand Down
33 changes: 33 additions & 0 deletions test/diagnostic_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
require_relative "helper"

module TypeProf
class DiagnosticTest < Test::Unit::TestCase
class DummyNode
def code_range
nil
end
end

def test_diagnostic_with_default_values
diag = Diagnostic.new(DummyNode.new, :code_range, "test message")
assert_equal :error, diag.severity
assert_nil diag.tags
end

def test_diagnostic_with_custom_severity
diag = Diagnostic.new(DummyNode.new, :code_range, "test message", severity: :warning)
assert_equal :warning, diag.severity
end

def test_diagnostic_with_custom_tags
diag = Diagnostic.new(DummyNode.new, :code_range, "test message", tags: [:deprecated])
assert_equal [:deprecated], diag.tags
end

def test_diagnostic_with_custom_severity_and_tags
diag = Diagnostic.new(DummyNode.new, :code_range, "test message", severity: :info, tags: [:experimental])
assert_equal :info, diag.severity
assert_equal [:experimental], diag.tags
end
end
end