Add keyword arguments for severity and tags in Diagnostic #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add severity and tags as keyword arguments to Diagnostic#initialize - Add attr_reader for tags attribute - Add comprehensive test cases in new test/diagnostic_test.rb - Remove TODO comments as the feature is now implemented Co-Authored-By: Masato Sugiyama <public@smasato.net>
mame
approved these changes
Mar 5, 2025
|
Sorry for the late review! I would like to add a configuration to set the default severity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Added test cases to verify: