Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless loaded file check #885

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Remove useless loaded file check #885

merged 1 commit into from
Feb 23, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Feb 23, 2024

It was doing nothing from the beginning
$" never includes "irb/command/load" but always includes "absolute/path/to/irb/command/load.rb"

#882 (comment)

st0012
st0012 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@tompng tompng mentioned this pull request Feb 23, 2024
Merged
@tompng tompng merged commit f6d4896 into ruby:master Feb 23, 2024
29 checks passed
@tompng tompng deleted the rm_useless_if branch February 23, 2024 13:11
matzbot pushed a commit to ruby/ruby that referenced this pull request Feb 23, 2024
@tompng @matzbot
[ruby/irb] Remove useless loaded file check
ea2fb74 
(ruby/irb#885)

ruby/irb@f6d489658e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tompng @st0012