Unroll extension method generation #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given we only have 2 remaining extension setter methods, both of which only take 1 argument and don't have any alias, the current method generation logic is overly complicated. This commit simplifies the method generation logic by simply defining the methods directly in the `IRB::Context` class.
tompng
approved these changes
Feb 23, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 23, 2024
(ruby/irb#882) * Unroll extension method generation Given we only have 2 remaining extension setter methods, both of which only take 1 argument and don't have any alias, the current method generation logic is overly complicated. This commit simplifies the method generation logic by simply defining the methods directly in the `IRB::Context` class. * Fix use_loader extension ruby/irb@67eba5401b
nobu
reviewed
Feb 23, 2024
| @@ -49,7 +49,7 @@ def use_loader=(opt) | |||
| if IRB.conf[:USE_LOADER] != opt | |||
| IRB.conf[:USE_LOADER] = opt | |||
| if opt | |||
| if !$".include?("irb/cmd/load") | |||
| if !$".include?("irb/command/load") | |||
There was a problem hiding this comment.
This if seems doing nothing from the beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we only have 2 remaining extension setter methods, both of which only take 1 argument and don't have any alias, the current method generation logic is overly complicated.
This PR simplifies the method generation logic by simply defining the methods directly in the
IRB::Contextclass.I also found that
use_loaderis broken and fixed it in a separate commit.