Skip nested IRB tests in Ruby Core CI #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the subprocess gets stuck in the nested IRB session until timed out. We don't have enough information to debug it yet, so skip the tests to unblock CI.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 9, 2023
(ruby/irb#675) Sometimes the subprocess gets stuck in the nested IRB session until timed out. We don't have enough information to debug it yet, so skip the tests to unblock CI. ruby/irb@606f18c80c
st0012
added a commit
that referenced
this pull request
Aug 11, 2023
We already skipped history integration tests in core CI in #675 due to suspicion on nested IRB sessions don't work on certain operating systems. But after #669, the evaluation integration test also started to fail on some Core CI suites. So, it looks like the integration test setup may not work in Core CI, at least in some suites. Consider `ruby/irb` already has rather sophisticated test suite, I think it's better to skip the integration tests in core CI for now.
st0012
added a commit
that referenced
this pull request
Aug 11, 2023
We already skipped history integration tests in core CI in #675 due to suspicion on nested IRB sessions don't work on certain operating systems. But after #669, the evaluation integration test also started to fail on some Core CI suites. So, it looks like the integration test setup may not work in Core CI, at least in some suites. Consider `ruby/irb` already has rather sophisticated test suite, I think it's better to skip the integration tests in core CI for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (or under some environments) the subprocess gets stuck in the nested IRB session until timed out (example). We don't have enough information to debug it yet, so skip the tests to unblock CI.