Skip to content

Commit

Permalink
Skip integration tests in core CI (#677)
Browse files Browse the repository at this point in the history
We already skipped history integration tests in core CI in #675 due to
suspicion on nested IRB sessions don't work on certain operating systems.

But after #669, the evaluation integration test also started to fail on
some Core CI suites. So, it looks like the integration test setup may not
work in Core CI, at least in some suites.

Consider `ruby/irb` already has rather sophisticated test suite, I think
it's better to skip the integration tests in core CI for now.
  • Loading branch information
st0012 authored Aug 11, 2023
1 parent 50185c2 commit 6f49b4c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
4 changes: 4 additions & 0 deletions test/irb/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ def setup
omit "Integration tests require PTY."
end

if ruby_core?
omit "This test works only under ruby/irb"
end

@envs = {}
end

Expand Down
4 changes: 0 additions & 4 deletions test/irb/test_debug_cmd.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ class DebugCommandTest < IntegrationTestCase
def setup
super

if ruby_core?
omit "This test works only under ruby/irb"
end

if RUBY_ENGINE == 'truffleruby'
omit "This test runs with ruby/debug, which doesn't work with truffleruby"
end
Expand Down
8 changes: 0 additions & 8 deletions test/irb/test_history.rb
Original file line number Diff line number Diff line change
Expand Up @@ -210,14 +210,6 @@ def with_temp_stdio
end

class NestedIRBHistoryTest < IntegrationTestCase
def setup
super

if ruby_core?
omit "This test works only under ruby/irb"
end
end

def test_history_saving_with_nested_sessions
write_history ""

Expand Down

0 comments on commit 6f49b4c

Please sign in to comment.