Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #608] skip strict validations #610

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

pirj
Copy link
Member

@pirj pirj commented Dec 31, 2021

fixes #608


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@pirj pirj force-pushed the fix-608-skip-on-strict branch from 6f34798 to 795d27e Compare December 31, 2021 15:37
@koic
Copy link
Member

koic commented Dec 31, 2021

This branch has conflicts. Can you rebase with the latest master branch?

@pirj pirj force-pushed the fix-608-skip-on-strict branch from 795d27e to 0da37d8 Compare January 1, 2022 14:28
@koic koic merged commit 089a35a into rubocop:master Jan 4, 2022
@koic
Copy link
Member

koic commented Jan 4, 2022

Thanks!

@pirj pirj deleted the fix-608-skip-on-strict branch January 4, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/RedundantPresenceValidationOnBelongsTo should not match strict validations
3 participants