[Fix #608] skip strict validations

changelog/fix_redundant_presence_validation_with_strict_validation.md

@@ -0,0 +1 @@
+* [#610](https://github.com/rubocop/rubocop-rails/pull/610): Fix autocorrection of strict validation for `Rails/RedundantPresenceValidationOnBelongsTo` cop. ([@pirj][])

lib/rubocop/cop/rails/redundant_presence_validation_on_belongs_to.rb

@@ -48,12 +48,21 @@ class RedundantPresenceValidationOnBelongsTo < Base
         #
         #   @example source that matches - by a foreign key
         #     validates :user_id, presence: true
+        #
+        #   @example source that DOES NOT match - strict validation
+        #     validates :user_id, strict: true
+        #
+        #   @example source that DOES NOT match - custom strict validation
+        #     validates :user_id, strict: MissingUserError
         def_node_matcher :presence_validation?, <<~PATTERN
           $(
             send nil? :validates
             (sym $_)
             ...
-            $(hash <$(pair (sym :presence) {true hash}) ...>)
+            $[
+              (hash <$(pair (sym :presence) {true hash}) ...>)  # presence: true
+              !(hash <$(pair (sym :strict) {true const}) ...>)  # strict: true
+            ]
           )
         PATTERN
 

spec/rubocop/cop/rails/redundant_presence_validation_on_belongs_to_spec.rb

@@ -189,6 +189,20 @@
         validates :author, presence: true
       RUBY
     end
+
+    it 'does not register an offense with strict validation' do
+      expect_no_offenses(<<~RUBY)
+        belongs_to :user
+        validates :user, presence: true, strict: true
+      RUBY
+    end
+
+    it 'does not register an offense with strict validation with an explicit exception class' do
+      expect_no_offenses(<<~RUBY)
+        belongs_to :user
+        validates :user, presence: true, strict: MissingUserError
+      RUBY
+    end
   end
 
   context 'Rails < 5.0', :rails42 do