Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions from CircleCI #1187

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

koic
Copy link
Member

@koic koic commented Nov 27, 2023

This PR will centralize CI to GitHub Actions as introduced in #1178.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the migrate_to_gha_from_circleci branch 2 times, most recently from 334dd15 to 31d2683 Compare November 28, 2023 03:14
This PR will centralize CI to GitHub Actions as introduced in
rubocop#1178.
@koic koic force-pushed the migrate_to_gha_from_circleci branch from 31d2683 to 082efb8 Compare November 28, 2023 15:51
@koic koic merged commit a27f6df into rubocop:master Nov 28, 2023
12 checks passed
@koic koic deleted the migrate_to_gha_from_circleci branch November 28, 2023 15:55
@Earlopain Earlopain mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant