Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require RuboCop AST 1.30.0+ #1178

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Conversation

koic
Copy link
Member

@koic koic commented Nov 5, 2023

Follow up rubocop/rubocop#12305.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit dc6cebc into rubocop:master Nov 5, 2023
4 checks passed
@koic koic deleted the require_rubocop_ast_1_30 branch November 5, 2023 16:36
koic added a commit to koic/rubocop-rails that referenced this pull request Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in
rubocop#1178.
koic added a commit to koic/rubocop-rails that referenced this pull request Nov 28, 2023
This PR will centralize CI to GitHub Actions as introduced in
rubocop#1178.
koic added a commit to koic/rubocop-rails that referenced this pull request Nov 28, 2023
This PR will centralize CI to GitHub Actions as introduced in
rubocop#1178.
koic added a commit to koic/rubocop-rails that referenced this pull request Nov 28, 2023
This PR will centralize CI to GitHub Actions as introduced in
rubocop#1178.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant